fix: Compile with Java 23 (language level 17) (#848)

Author: CharlesDuboisSAP

codestyle/pmd.xml

@@ -27,7 +27,7 @@
   <rule ref="category/java/design.xml/AvoidThrowingRawExceptionTypes">
     <priority>3</priority>
   </rule>
-  <rule ref="category/java/errorprone.xml/NonCaseLabelInSwitchStatement">
+  <rule ref="category/java/errorprone.xml/NonCaseLabelInSwitch">
     <priority>3</priority>
   </rule>
   <rule ref="category/java/bestpractices.xml/PreserveStackTrace">

datamodel/odata-generator-utility/src/main/java/com/sap/cloud/sdk/datamodel/odata/utility/ServiceNameMappings.java

@@ -38,18 +38,25 @@ private record Value( @Nonnull String value, @Nonnull String comment )
     {
     }
 
+    private ServiceNameMappings( @Nonnull final Path file )
+    {
+        this.file = file;
+    }
+
     /**
      * Creates a new instance of {@link ServiceNameMappings} with the specified file.
      *
      * @param file
      *            the file to read and write mappings from/to
      */
-    public ServiceNameMappings( @Nonnull final Path file )
+    @Nonnull
+    public static ServiceNameMappings load( @Nonnull final Path file )
     {
-        this.file = file;
+        final ServiceNameMappings mappings = new ServiceNameMappings(file);
         if( Files.exists(file) ) {
-            populateMappings();
+            mappings.populateMappings();
         }
+        return mappings;
     }
 
     /**

datamodel/odata-v4/odata-v4-generator/src/main/java/com/sap/cloud/sdk/datamodel/odatav4/generator/ODataToVdmGenerator.java

@@ -293,7 +293,7 @@ private void cleanDirectory( final File outputDir )
 
     private ServiceNameMappings loadPropertiesConfiguration( final File serviceMappingsFile )
     {
-        return new ServiceNameMappings(serviceMappingsFile.toPath());
+        return ServiceNameMappings.load(serviceMappingsFile.toPath());
     }
 
     // Schema definitions are necessary to make the EDMX properties explorable through Olingo API at runtime, example:
@@ -334,7 +334,7 @@ static List<CsdlSchema> loadEdmxSchemas()
     private void storeConfiguration( final File serviceMappingsFile, final Iterable<Service> allODataServices )
     {
         ensureFileExists(serviceMappingsFile);
-        final ServiceNameMappings mappings = new ServiceNameMappings(serviceMappingsFile.toPath());
+        final ServiceNameMappings mappings = ServiceNameMappings.load(serviceMappingsFile.toPath());
 
         for( final Service oDataService : allODataServices ) {
             final String javaClassNameKey = oDataService.getName() + Service.SERVICE_MAPPINGS_CLASS_SUFFIX;

datamodel/odata/odata-generator/src/main/java/com/sap/cloud/sdk/datamodel/odata/generator/ODataToVdmGenerator.java

@@ -288,13 +288,13 @@ private void cleanDirectory( final File outputDir )
 
     private ServiceNameMappings loadPropertiesConfiguration( final File serviceMappingsFile )
     {
-        return new ServiceNameMappings(serviceMappingsFile.toPath());
+        return ServiceNameMappings.load(serviceMappingsFile.toPath());
     }
 
     private void storeConfiguration( final File serviceMappingsFile, final Iterable<Service> allODataServices )
     {
         ensureFileExists(serviceMappingsFile);
-        final ServiceNameMappings mappings = new ServiceNameMappings(serviceMappingsFile.toPath());
+        final ServiceNameMappings mappings = ServiceNameMappings.load(serviceMappingsFile.toPath());
 
         for( final Service oDataService : allODataServices ) {
             final String javaClassNameKey = oDataService.getName() + Service.SERVICE_MAPPINGS_CLASS_SUFFIX;