Improve Naming

Author: newtork

cloudplatform/connectivity-apache-httpclient5/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/ConnectionPoolManagerProviders.java

@@ -238,7 +238,7 @@ public ConnectionPoolManagerProvider byDestinationName()
         }
 
         @Nonnull
-        public ConnectionPoolManagerProvider byIndicatedBehalfOf()
+        public ConnectionPoolManagerProvider byOnBehalfOf()
         {
             return by(destination -> {
                 // Check if the destination has any OnBehalfOf indicators in its custom header providers

cloudplatform/connectivity-apache-httpclient5/src/test/java/com/sap/cloud/sdk/cloudplatform/connectivity/ConnectionPoolManagerProvidersTest.java

@@ -249,9 +249,9 @@ void testFunctionalInterfaceCanBeUsedWithLambda()
     }
 
     @Test
-    void testCachedByIndicatedBehalfOfWithCurrentTenantHeaderProvider()
+    void testCachedByOnBehalfOfWithCurrentTenantHeaderProvider()
     {
-        final ConnectionPoolManagerProvider provider = ConnectionPoolManagerProviders.cached().byIndicatedBehalfOf();
+        final ConnectionPoolManagerProvider provider = ConnectionPoolManagerProviders.cached().byOnBehalfOf();
 
         // Create a header provider that indicates NAMED_USER_CURRENT_TENANT
         final DestinationHeaderProvider namedUserProvider =
@@ -286,9 +286,9 @@ void testCachedByIndicatedBehalfOfWithCurrentTenantHeaderProvider()
     }
 
     @Test
-    void testCachedByIndicatedBehalfOfWithTechnicalUserCurrentTenant()
+    void testCachedByOnBehalfOfWithTechnicalUserCurrentTenant()
     {
-        final ConnectionPoolManagerProvider provider = ConnectionPoolManagerProviders.cached().byIndicatedBehalfOf();
+        final ConnectionPoolManagerProvider provider = ConnectionPoolManagerProviders.cached().byOnBehalfOf();
 
         final DefaultHttpDestination dest =
             DefaultHttpDestination
@@ -311,9 +311,9 @@ void testCachedByIndicatedBehalfOfWithTechnicalUserCurrentTenant()
     }
 
     @Test
-    void testCachedByIndicatedBehalfOfWithProviderUserSharesAcrossTenants()
+    void testCachedByOnBehalfOfWithProviderUserSharesAcrossTenants()
     {
-        final ConnectionPoolManagerProvider provider = ConnectionPoolManagerProviders.cached().byIndicatedBehalfOf();
+        final ConnectionPoolManagerProvider provider = ConnectionPoolManagerProviders.cached().byOnBehalfOf();
 
         // Create a header provider that indicates TECHNICAL_USER_PROVIDER (not current tenant)
         final DefaultHttpDestination dest =
@@ -336,9 +336,9 @@ void testCachedByIndicatedBehalfOfWithProviderUserSharesAcrossTenants()
     }
 
     @Test
-    void testCachedByIndicatedBehalfOfWithNoHeaderProvider()
+    void testCachedByOnBehalfOfWithNoHeaderProvider()
     {
-        final ConnectionPoolManagerProvider provider = ConnectionPoolManagerProviders.cached().byIndicatedBehalfOf();
+        final ConnectionPoolManagerProvider provider = ConnectionPoolManagerProviders.cached().byOnBehalfOf();
 
         // Destination without any header provider
         final DefaultHttpDestination dest = DefaultHttpDestination.builder("http://example.com").build();
@@ -357,9 +357,9 @@ void testCachedByIndicatedBehalfOfWithNoHeaderProvider()
     }
 
     @Test
-    void testCachedByIndicatedBehalfOfWithNonDefaultHttpDestination()
+    void testCachedByOnBehalfOfWithNonDefaultHttpDestination()
     {
-        final ConnectionPoolManagerProvider provider = ConnectionPoolManagerProviders.cached().byIndicatedBehalfOf();
+        final ConnectionPoolManagerProvider provider = ConnectionPoolManagerProviders.cached().byOnBehalfOf();
 
         // Non-DefaultHttpDestination should return null key and create new manager each time
         final HttpDestinationProperties nonDefaultDest = DefaultHttpDestination.builder("http://example.com").build();

release_notes.md

@@ -19,11 +19,11 @@
   ```java
   ApacheHttpClient5Factory factory = new ApacheHttpClient5FactoryBuilder()
     .connectionPoolManagerProvider(ConnectionPoolManagerProviders.noCache()) // new API (default behavior)
-    .connectionPoolManagerProvider(ConnectionPoolManagerProviders.cached().byIndicatedBehalfOf()) // new API
+    .connectionPoolManagerProvider(ConnectionPoolManagerProviders.cached().byOnBehalfOf()) // new API
     .build();
   ```
-  Available caching strategies include `byCurrentTenant()`, `byDestinationName()`, `byIndicatedBehalfOf()`, and custom key extractors via `by(Function)`.
-  The `byIndicatedBehalfOf()` strategy intelligently determines tenant isolation requirements based on the destination's `OnBehalfOf` indication.
+  Available caching strategies include `byCurrentTenant()`, `byDestinationName()`, `byOnBehalfOf()`, and custom key extractors via `by(Function)`.
+  The `byOnBehalfOf()` strategy intelligently determines tenant isolation requirements based on the destination's `OnBehalfOf` indication.
 
 ### 📈 Improvements