Merge branch 'refs/heads/fix-caching-getOrComputeAllDestinations' into add-preLookup-Check

Author: Jonas-Isr

.github/dependabot.yaml

@@ -49,6 +49,9 @@ updates:
         versions: ['3.6.1', '3.6.2']
       - dependency-name: 'com.sap.cloud.security:env'
         versions: ['3.6.1', '3.6.2']
+      # needs Java 21
+      - dependency-name: 'com.puppycrawl.tools:checkstyle'
+        versions: [ ">=13.0.0" ]
 
   # archetype updates
   # Dependabot seems to be unable to handle those, so this is disabled for now

cloudplatform/connectivity-destination-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/DestinationService.java

@@ -881,6 +881,11 @@ private static Try<Destination> getOrComputeDestination(
             @Nullable
             final GetOrComputeAllDestinationsCommand getAllCommand;
             if( changeDetectionEnabled ) {
+                if( isUsingExperimentalFeatures(options) ) {
+                    log
+                        .warn(
+                            "Using change detection together with either fragments, cross-level options, or custom headers is discouraged and might lead to unexpected caching behaviour.");
+                }
                 getAllCommand =
                     GetOrComputeAllDestinationsCommand
                         .prepareCommand(
@@ -915,7 +920,7 @@ private static Try<List<DestinationProperties>> getOrComputeAllDestinations(
             if( isUsingExperimentalFeatures(options) ) {
                 log
                     .warn(
-                        "Using cache/change detection together with either fragments, cross-level options, or custom headers is discouraged and might lead to unexpected behaviour.");
+                        "Using caching together with either fragments, cross-level options, or custom headers is discouraged and might lead to unexpected caching behaviour.");
             }
 
             return GetOrComputeAllDestinationsCommand

cloudplatform/connectivity-destination-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/GetOrComputeSingleDestinationCommand.java

@@ -8,13 +8,13 @@
 import java.util.Objects;
 import java.util.concurrent.locks.ReentrantLock;
 import java.util.function.BiFunction;
+import java.util.function.Function;
 import java.util.function.Supplier;
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 
 import com.github.benmanes.caffeine.cache.Cache;
-import com.google.common.base.Functions;
 import com.sap.cloud.sdk.cloudplatform.cache.CacheKey;
 import com.sap.cloud.sdk.cloudplatform.connectivity.exception.DestinationAccessException;
 import com.sap.cloud.sdk.cloudplatform.security.principal.exception.PrincipalAccessException;
@@ -273,7 +273,7 @@ private static boolean certificateIsExpired( final Destination destination )
         return destination
             .get(DestinationProperty.CERTIFICATES)
             .toStream()
-            .flatMap(Functions.identity())
+            .flatMap(Function.identity())
             .map(t -> ((DestinationServiceV1Response.DestinationCertificate) t).getExpiryTimestamp())
             .filter(Objects::nonNull)
             .min()
@@ -286,7 +286,7 @@ private static boolean authTokenIsExpired( @Nonnull final Destination destinatio
         return destination
             .get(DestinationProperty.AUTH_TOKENS)
             .toStream()
-            .flatMap(Functions.identity())
+            .flatMap(Function.identity())
             .map(t -> ((DestinationServiceV1Response.DestinationAuthToken) t).getExpiryTimestamp())
             .filter(Objects::nonNull)
             .min()

datamodel/odata-v4/odata-v4-core/src/main/java/com/sap/cloud/sdk/datamodel/odatav4/adapter/JacksonVdmObjectSerializer.java

@@ -5,6 +5,7 @@
 import java.util.Arrays;
 import java.util.Map;
 import java.util.Optional;
+import java.util.function.Function;
 import java.util.stream.Collectors;
 
 import javax.annotation.Nonnull;
@@ -20,7 +21,6 @@
 import com.fasterxml.jackson.databind.introspect.AnnotationMap;
 import com.fasterxml.jackson.databind.ser.ContextualSerializer;
 import com.fasterxml.jackson.databind.ser.std.StdSerializer;
-import com.google.common.base.Functions;
 import com.sap.cloud.sdk.datamodel.odatav4.core.VdmEntity;
 import com.sap.cloud.sdk.datamodel.odatav4.core.VdmObject;
 import com.sap.cloud.sdk.result.ElementName;
@@ -79,7 +79,7 @@ public void serialize(
             Arrays
                 .stream(object.getClass().getDeclaredFields())
                 .filter(f -> f.getAnnotation(ElementName.class) != null)
-                .collect(Collectors.toMap(Functions.identity(), f -> getFieldValue(f, object)));
+                .collect(Collectors.toMap(Function.identity(), f -> getFieldValue(f, object)));
 
         for( final Map.Entry<Field, Option<Object>> propertyEntry : fieldValues.entrySet() ) {
             final Option<Object> propertyValueOption = propertyEntry.getValue();

release_notes.md

@@ -8,7 +8,9 @@
 
 ### 🔧 Compatibility Notes
 
-- 
+- We noticed an implicit behavior change for updated Apache HttpClient from `5.5.1` to `5.6`.
+  TLS/SSL connections are now checked for hostname verification on behalf of the provided server certificate.
+  Even with enabled trust-all-certificates flag, connections to servers with mismatching hostnames will be rejected.
 
 ### ✨ New Functionality