PMD

Author: Jonas-Isr

cloudplatform/connectivity-apache-httpclient5/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/ApacheHttpClient5Wrapper.java

@@ -135,8 +135,7 @@ public RequestConfig getConfig()
     public URI mergeRequestUri( @Nonnull final URI requestUri )
     {
         final UriPathMerger merger = new UriPathMerger();
-        URI merged;
-        merged = merger.merge(destination.getUri(), requestUri);
+        final URI merged = merger.merge(destination.getUri(), requestUri);
         final String queryString = String.join("&", QueryParamGetter.getQueryParameters(destination));
         return merger.merge(merged, URI.create("/?" + queryString));
     }

datamodel/odata-client-apache-httpclient5/src/main/java/com/sap/cloud/sdk/datamodel/odata/client/request/HttpEntityReader.java

@@ -112,6 +112,7 @@ static <T> T read(
      * @throws ODataDeserializationException
      *             When streamed deserialization process failed.
      */
+    @SuppressWarnings( "PMD.CloseResource" ) // response lifecycle is owned by the caller via ODataRequestResult (Closeable)
     static <T> T stream(
         @Nonnull final ODataRequestResult result,
         @Nonnull final CheckedFunction1<JsonReader, T> readerConsumer )

datamodel/odata-client-apache-httpclient5/src/main/java/com/sap/cloud/sdk/datamodel/odata/client/request/MultipartHttpResponse.java

@@ -132,7 +132,7 @@ private static ContentType withFallbackCharset( @Nonnull final ContentType conte
             return contentType;
         }
         return contentType
-            .withParameters(new BasicNameValuePair("charset", MultipartHttpResponse.DEFAULT_CHARSET.name()));
+            .withParameters(new BasicNameValuePair("charset", DEFAULT_CHARSET.name()));
     }
 
     @Nonnull
@@ -150,13 +150,19 @@ private static StatusLine getStatusLine( @Nonnull final String firstLine )
         return new StatusLine(HttpVersion.HTTP_1_1, 0, "Unknown");
     }
 
+    // Parameters are mandated by the Java serialization mechanism and cannot be removed.
+    // The method unconditionally throws to prevent serialization of this class.
+    @SuppressWarnings( "PMD.UnusedFormalParameter" )
     @Serial
     private void readObject( java.io.ObjectInputStream in )
         throws java.io.NotSerializableException
     {
         throw new java.io.NotSerializableException(getClass().getName());
     }
 
+    // Parameters are mandated by the Java serialization mechanism and cannot be removed.
+    // The method unconditionally throws to prevent serialization of this class.
+    @SuppressWarnings( "PMD.UnusedFormalParameter" )
     @Serial
     private void writeObject( java.io.ObjectOutputStream out )
         throws java.io.NotSerializableException

datamodel/odata-client-apache-httpclient5/src/main/java/com/sap/cloud/sdk/datamodel/odata/client/request/ODataHealthyResponseValidator.java

@@ -36,6 +36,7 @@ class ODataHealthyResponseValidator
      * @throws ODataServiceErrorException
      *             When the response contains an OData error message according to specification.
      */
+    @SuppressWarnings( "PMD.CloseResource" ) // response lifecycle is owned by the caller
     static void requireHealthyResponse( @Nonnull final ODataRequestResult result )
     {
         final ODataRequestGeneric originalRequest = result.getODataRequest();

datamodel/odata-client-apache-httpclient5/src/main/java/com/sap/cloud/sdk/datamodel/odata/client/request/ODataRequestResultGeneric.java

@@ -25,7 +25,6 @@
 import org.apache.hc.core5.http.ClassicHttpResponse;
 import org.apache.hc.core5.http.ContentType;
 import org.apache.hc.core5.http.HttpEntity;
-import org.apache.hc.core5.http.HttpResponse;
 import org.apache.hc.core5.http.io.entity.EntityUtils;
 import org.apache.hc.core5.http.message.StatusLine;
 
@@ -402,6 +401,7 @@ private <T> T getPrimitiveObjectFromJson(
                     e));
     }
 
+    @SuppressWarnings( "PMD.CloseResource" ) // The response is not being consumed here, closing it here would prematurely end the response.
     @Nonnull
     private <T> T getPrimitiveObjectFromPlainText( @Nonnull final Class<T> objectType )
         throws ODataDeserializationException

datamodel/odata-client-apache-httpclient5/src/main/java/com/sap/cloud/sdk/datamodel/odata/client/request/ODataRequestResultMultipartGeneric.java

@@ -94,6 +94,7 @@ public ODataRequestBatch getODataRequest()
      * @throws ODataServiceErrorException
      *             When the response contains an OData error message according to specification.
      */
+    @SuppressWarnings( "PMD.CloseResource" ) // response lifecycle is owned by the caller
     @Nonnull
     @Override
     public ODataRequestResultGeneric getResult( @Nonnull final ODataRequestGeneric request )
@@ -166,6 +167,7 @@ private Try<List<List<ClassicHttpResponse>>> loadBatchResponses()
      *
      * @since 5.5.0
      */
+    @SuppressWarnings( "PMD.CloseResource" )
     @Override
     public void close()
     {