Skip to content

Commit dc35cf0

Browse files
committed
Refine comments
1 parent 10592bd commit dc35cf0

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

datamodel/odata-client/src/test/java/com/sap/cloud/sdk/datamodel/odata/client/request/ODataNextLinkTest.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,9 @@ static class Expectation
9393
.expects(
9494
QueryParameterCase.Expectation
9595
.builder()
96-
.initialQuerySent("dest1=one&dest2=two&odata1=one&odata2=two&prop1=one&prop2=two") // destination parameters + odata-request parameters + properties parameters
97-
.nextLinkQueryParsed("$skiptoken=42&next1=one&next2=two") // parsed next-link with removed redundant query parameters
98-
.nextLinkQuerySent("dest1=one&dest2=two&$skiptoken=42&next1=one&next2=two&prop1=one&prop2=two") // destination parameters + next-link parameters + properties parameters
96+
.initialQuerySent("dest1=one&dest2=two&odata1=one&odata2=two&prop1=one&prop2=two")
97+
.nextLinkQueryParsed("$skiptoken=42&next1=one&next2=two")
98+
.nextLinkQuerySent("dest1=one&dest2=two&$skiptoken=42&next1=one&next2=two&prop1=one&prop2=two")
9999
.build()),
100100

101101
// case 2: query-parameters from destination uri, destination properties, next-link and odata-request with equal values
@@ -112,9 +112,9 @@ static class Expectation
112112
.expects(
113113
QueryParameterCase.Expectation
114114
.builder()
115-
.initialQuerySent("dest1=one&dest2=two&odata1=one&odata2=two&prop1=one&prop2=two") // destination parameters + odata-request parameters + properties parameters
116-
.nextLinkQueryParsed("$skiptoken=42&next1=one&odata1=one") // parsed next-link with removed redundant query parameters
117-
.nextLinkQuerySent("dest1=one&dest2=two&$skiptoken=42&next1=one&odata1=one&prop1=one&prop2=two") // destination parameters + next-link parameters + properties parameters
115+
.initialQuerySent("dest1=one&dest2=two&odata1=one&odata2=two&prop1=one&prop2=two")
116+
.nextLinkQueryParsed("$skiptoken=42&next1=one&odata1=one")
117+
.nextLinkQuerySent("dest1=one&dest2=two&$skiptoken=42&next1=one&odata1=one&prop1=one&prop2=two")
118118
.build()),
119119

120120
// case 3: query-parameters from next link may be in conflict with destination uri or destination properties
@@ -131,8 +131,8 @@ static class Expectation
131131
.expects(
132132
QueryParameterCase.Expectation
133133
.builder()
134-
.initialQuerySent("dest1=one&dest2=two&odata1=one&odata2=two&prop1=one&prop2=two") // destination parameters + odata-request parameters + properties parameters
135-
.nextLinkQueryParsed("$skiptoken=42&next1=eins&dest1=eins&prop1=eins&odata1=eins") // parsed next-link with conflicting parameter values
134+
.initialQuerySent("dest1=one&dest2=two&odata1=one&odata2=two&prop1=one&prop2=two")
135+
.nextLinkQueryParsed("$skiptoken=42&next1=eins&dest1=eins&prop1=eins&odata1=eins")
136136
.nextLinkQuerySent(
137137
"dest1=one&dest2=two" // destination parameters
138138
+ "&$skiptoken=42&next1=eins&dest1=eins&prop1=eins&odata1=eins" // next-link parameters
@@ -154,9 +154,9 @@ static class Expectation
154154
.expects(
155155
QueryParameterCase.Expectation
156156
.builder()
157-
.initialQuerySent("foo=bar&foo=bar&foo=bar") // destination parameters + odata-request parameters + properties parameters
158-
.nextLinkQueryParsed("$skiptoken=42") // parsed next-link with removed redundant query parameters
159-
.nextLinkQuerySent("foo=bar&$skiptoken=42&foo=bar") // destination parameters + next-link parameters + properties parameters
157+
.initialQuerySent("foo=bar&foo=bar&foo=bar") // 3x due to initial OData request parameter
158+
.nextLinkQueryParsed("$skiptoken=42")
159+
.nextLinkQuerySent("foo=bar&$skiptoken=42&foo=bar")
160160
.build()),
161161

162162
};

0 commit comments

Comments
 (0)