feat: [Connectivity] Dynamic Keystore in HttpDestination#1202
Open
MatKuhr wants to merge 6 commits into
Open
Conversation
…ion-keystore # Conflicts: # cloudplatform/connectivity-oauth/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/OAuth2Options.java
MatKuhr
commented
Jun 12, 2026
| * The {@link KeyStore} to be used when communicating over HTTP. | ||
| */ | ||
| @Nonnull | ||
| public Builder keyStore( @Nullable final KeyStore keyStore ) |
Member
Author
There was a problem hiding this comment.
no new public API, just replaces the previous public @Setter
MatKuhr
commented
Jun 12, 2026
| @Nullable | ||
| private final KeyStore keyStore; | ||
| @Nonnull | ||
| private final Supplier<Option<KeyStore>> keyStore; |
Member
Author
There was a problem hiding this comment.
Supplier<Option<KeyStore>> looks a bit strange, but this is because allowing a supplier to return null is often dangerous (especially, because our current annotations don't allow declaring Supplier<@Nullable KeyStore>). This solution was the least un-intuitive variant I could find that allows for the KeyStore to be null but still using a supplier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Follow-up for #1142
Allows in-place rotation for destination keystore to fully support #1134
Feature scope:
DefaultHttpDestinationto supportSupplier<Keystore>OAuth2ServiceBindingDestinationLoaderand related classes to use this capabilityDefinition of Done
Documentation updated