chore: Handle update

Author: davidkna-sap

packages/openapi-generator/src/parser/media-type.spec.ts

@@ -475,21 +475,23 @@ describe('parseTopLevelMediaType', () => {
     });
   });
 
-  it('throws error with malformed content type', async () => {
+  it('parses malformed content type leniently (strips bad params)', async () => {
     const schema = {
       type: 'object',
       properties: { file: { type: 'string', format: 'binary' } }
     };
     const encoding = { file: { contentType: 'image/png;;invalid' } };
-    const refs = await createTestRefs();
+    const result = parseTopLevelMediaType(
+      createMultipartFormContent(schema, encoding),
+      await createTestRefs(),
+      defaultOptions
+    );
 
-    expect(() =>
-      parseTopLevelMediaType(
-        createMultipartFormContent(schema, encoding),
-        refs,
-        defaultOptions
-      )
-    ).toThrow(/invalid content type.*image\/png;;invalid.*file/i);
+    expect(result?.encoding?.file).toEqual({
+      contentType: 'image/png;;invalid',
+      isImplicit: false,
+      parsedContentTypes: [{ type: 'image/png', parameters: {} }]
+    });
   });
 
   it('handles wildcard content types correctly', async () => {
@@ -509,25 +511,27 @@ describe('parseTopLevelMediaType', () => {
     });
   });
 
-  it('throws error with completely invalid content type format', async () => {
+  it('parses completely invalid content type leniently', async () => {
     const schema = {
       type: 'object',
       properties: { attachment: { type: 'string', format: 'binary' } }
     };
     const encoding = {
       attachment: { contentType: 'not-a-valid-content-type-at-all' }
     };
-    const refs = await createTestRefs();
-
-    expect(() =>
-      parseTopLevelMediaType(
-        createMultipartFormContent(schema, encoding),
-        refs,
-        defaultOptions
-      )
-    ).toThrow(
-      /invalid content type.*not-a-valid-content-type-at-all.*attachment/i
+    const result = parseTopLevelMediaType(
+      createMultipartFormContent(schema, encoding),
+      await createTestRefs(),
+      defaultOptions
     );
+
+    expect(result?.encoding?.attachment).toEqual({
+      contentType: 'not-a-valid-content-type-at-all',
+      isImplicit: false,
+      parsedContentTypes: [
+        { type: 'not-a-valid-content-type-at-all', parameters: {} }
+      ]
+    });
   });
 });
 

packages/openapi-generator/src/parser/media-type.ts

@@ -1,5 +1,5 @@
-import { createLogger, ErrorWithCause } from '@sap-cloud-sdk/util';
-import { parse as parseContentType, type ParsedMediaType } from 'content-type';
+import { createLogger } from '@sap-cloud-sdk/util';
+import { parse as parseContentType, type ContentType } from 'content-type';
 import { parseSchema } from './schema';
 import type { OpenAPIV3 } from 'openapi-types';
 import type { OpenApiMediaTypeObject, OpenApiSchema } from '../openapi-types';
@@ -19,36 +19,16 @@ const allowedMediaTypes = [
 interface EncodingInfo {
   contentType: string;
   isImplicit: boolean;
-  parsedContentTypes: ParsedMediaType[];
+  parsedContentTypes: ContentType[];
 }
 
 type EncodingMap = Record<string, EncodingInfo>;
 
-/**
- * Parse content types from a comma-separated content type string.
- * @param contentType - Comma-separated content types from encoding object.
- * @param propName - Property name for error messages.
- * @returns Array of parsed content types.
- */
-function parseContentTypes(
-  contentType: string,
-  propName: string
-): ParsedMediaType[] {
+function parseContentTypes(contentType: string): ContentType[] {
   return contentType
     .split(',')
     .map(ct => ct.trim())
-    .map(ct => {
-      try {
-        return parseContentType(ct);
-      } catch (error: any) {
-        throw new ErrorWithCause(
-          `Invalid content type '${ct}' for property '${propName}' in OpenAPI specification. ` +
-            "Content types must follow the format 'type/subtype' (e.g., 'image/png', 'text/plain'). " +
-            'Please fix your OpenAPI document.',
-          error
-        );
-      }
-    });
+    .map(ct => parseContentType(ct));
 }
 
 /**
@@ -128,7 +108,7 @@ function inferMultipartFormEncodings(
         {
           contentType,
           isImplicit: true,
-          parsedContentTypes: parseContentTypes(contentType, propName)
+          parsedContentTypes: parseContentTypes(contentType)
         }
       ];
     })
@@ -158,10 +138,7 @@ function parseMultipartFormEncodings(
             {
               contentType: encodingObj.contentType!,
               isImplicit: false,
-              parsedContentTypes: parseContentTypes(
-                encodingObj.contentType!,
-                propName
-              )
+              parsedContentTypes: parseContentTypes(encodingObj.contentType!)
             }
           ])
       )