feat: Remove XSUAA binding dependency from destination retrieval flow#5879
Merged
Conversation
KavithaSiva
changed the title
….com/SAP/cloud-sdk-js into feat/reduce-XSUAA-binding-dependency
tomfrenken
reviewed
Jun 23, 2025
tomfrenken
reviewed
Jun 23, 2025
tomfrenken
reviewed
Jun 23, 2025
tomfrenken
approved these changes
Jun 23, 2025
tomfrenken
left a comment
tomfrenken
left a comment
Contributor
There was a problem hiding this comment.
LGTM, some notes left, but I leave it up to you since it's only [pp]
Contributor
Author
|
@deekshas8 @jjtang1985 I also removed the JWT verification step while trying to fetch a destination(as it is relying on XSUAA binding). |
ZhongpinWang
previously requested changes
Jun 24, 2025
ZhongpinWang
left a comment
ZhongpinWang
left a comment
Contributor
There was a problem hiding this comment.
Mostly LGTM, some minors.
Co-authored-by: Zhongpin Wang <zhongpin.wang@sap.com>
Co-authored-by: Zhongpin Wang <zhongpin.wang@sap.com>
….com/SAP/cloud-sdk-js into feat/reduce-XSUAA-binding-dependency
KavithaSiva
commented
Jun 27, 2025
| name: 'FORWARD-TOKEN-NOAUTH' | ||
| }; | ||
|
|
||
| function responseWithPublicKey(key: string = publicKey) { |
Contributor
Author
There was a problem hiding this comment.
For reviewer, this was originally imported from the verify test file, I just moved the function in here as I deleted the verify test file.
KavithaSiva
force-pushed
the
feat/reduce-XSUAA-binding-dependency
branch
from
ec32f73 to
fa79568
Compare
deekshas8
previously requested changes
Jun 30, 2025
Co-authored-by: Deeksha Sinha <88374536+deekshas8@users.noreply.github.com>
Co-authored-by: Deeksha Sinha <88374536+deekshas8@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes SAP/cloud-sdk-backlog#1274.
Changes have been tested manually in an E2E test, I used both an user IAS JWT and user XSUAA JWT to test destination(s) retrievals.
Working E2E test run: https://github.tools.sap/cloudsdk/sdk-js/actions/runs/15330543 with a canary release of these changes.