add csrf handling to v4 migration guide#2122
Closed
johannes-vogel wants to merge 1 commit into
Closed
Conversation
According to https://sap.github.io/cloud-sdk/docs/js/features/connectivity/csrf, this is also a breaking change that stakeholders should be aware of. I just copy pasted the note. Please enhance the description and add links if needed
Contributor
|
@johannes-vogel This was planned at some point but didn’t make it into v4, so the behavior remains unchanged from v3. We had missed removing the note — thank you for bringing it to our attention. I've removed it in a separate PR, so I’ll go ahead and close this one. Sorry for the confusion. |
Author
|
@deekshas8 Thanks for your quick response. Makes sense and also fits my observation while debugging after opening the PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://sap.github.io/cloud-sdk/docs/js/features/connectivity/csrf, this is also a breaking change that stakeholders should be aware of.
I just copy pasted the note. Please enhance the description and add links if needed
What Has Changed?
Explain what you are changing and why, if it isn't obvious from the diff.