fix: Add fragment list to model for custom fragments#4601
Conversation
🦋 Changeset detectedLatest commit: 355ebcc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
SummaryThe following content is AI-generated and provides a summary of the pull request: Fix: Add Fragment List to Model for All Custom Fragment Dialog TypesBug Fix🐛 Resolved an issue where the fragment list was not being added to the model for custom fragments when the dialog type was not Previously, The fix ensures Changes
GitHub Issues
PR Bot InformationVersion:
|
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looking at the diff, the change is straightforward: addFragmentListToModel() is now always called regardless of dialog type, and isCustomColumnFragment is simplified to a const boolean expression.
The logic change is correct and matches the PR description. Let me check one thing about the AddCustomFragmentOptions type to confirm all possible type values are accounted for.
Looking at line 44 of the controller: type: 'section' | 'tableColumn' — only two values exist, and the fix correctly handles both. The isCustomColumnFragment flag still correctly identifies tableColumn type.
The change is clean, the tests cover the behavior, and no existing comments need follow-up. The simplification is correct — the fragment list should be available for all dialog types.
The PR makes a focused, correct fix: unconditionally calling addFragmentListToModel() so all dialog types have the fragment list available in the model, while also simplifying the boolean assignment to use const. The changeset is properly included and covers both affected packages.
Jimmy-Joseph19
left a comment
Jimmy-Joseph19
left a comment
There was a problem hiding this comment.
Thanks for the fix. Approving.
Did not test locally and Integration test passed - https://github.com/SAP/open-ux-tools/actions/runs/24999167357
Changeset found.
nikmace
left a comment
nikmace
left a comment
There was a problem hiding this comment.
Change looks good
Did not test manually
Changeset is OK
|
…t_take2 * origin/main: Project modules update 12.05.2026 (5242) (#4661) update skill name (#4658) chore: apply latest changesets feat: Display unhandled exceptions from the Controller extension inside the Info Center. (#4627) chore: apply latest changesets feat: update splitter for new ui (#4648) chore: apply latest changesets tbi(generator-odata-downloader): Make self contained (#4656) chore: apply latest changesets fix: change confirm replace additional message based on environment (#4628) chore: apply latest changesets fix(sap-systems-ext): add new create new command (#4645) chore: apply latest changesets (fiori-mcp-server) add additional guidance on the adding of extension in fiori (#4643) test: update skill (#4651) chore: apply latest changesets fix: Add fragment list to model for custom fragments (#4601) chore: apply latest changesets Docs(eslint-plugin-fiori-tools): add cds code snippets to rule documentation (#4623)
3 participants
#4602
tableColumn. This meant other dialog types (e.g., custom fragments not tied to table columns) were missing the fragment list in the model entirely. This change ensuresaddFragmentListToModel()is always called, regardless of the dialog type.