feat: sap-no-commas-in-section-titles#4614
Draft
marufrasully wants to merge 2 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 404a20e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New ESLint Rule:
sap-no-commas-in-section-titlesNew Feature
✨ Adds a new ESLint rule
sap-no-commas-in-section-titlesto the@sap-ux/eslint-plugin-fiori-toolsplugin. This rule detects commas inUI.FacetsandUI.HeaderFacetsLabelvalues in OData annotation files (V2 and V4), preventing a silent runtime bug where commas break backend message grouping in SAP Fiori elements object pages.The rule is registered as
'error'in therecommended-for-s4hanaconfig and is not auto-fixable, since the correct replacement depends on the developer's intent.Changes
.agents/skills/fiori-eslint-dev/SKILL.md: New AI agent skill guide documenting the complete step-by-step workflow for developing ESLint rules in this monorepo..changeset/eslint-plugin-no-commas-in-section-titles.md: Minor version changeset entry for the new rule.packages/eslint-plugin-fiori-tools/src/rules/sap-no-commas-in-section-titles.ts: Core rule implementation. TraversesUI.FacetsandUI.HeaderFacetscollections (including nestedCollectionFacetsubsections) and reports anyLabelPropertyValuecontaining a comma.packages/eslint-plugin-fiori-tools/src/language/diagnostics.ts: Added theNO_COMMAS_IN_SECTION_TITLESconstant and theNoCommasInSectionTitlesdiagnostic interface, and included it in theDiagnosticunion type.packages/eslint-plugin-fiori-tools/src/rules/index.ts: Registered the new rule and imported its module.packages/eslint-plugin-fiori-tools/src/index.ts: Added'@sap-ux/fiori-tools/sap-no-commas-in-section-titles': 'error'to therecommended-for-s4hanaconfig.packages/eslint-plugin-fiori-tools/test/rules/sap-no-commas-in-section-titles.test.ts: Unit tests covering valid cases (no comma, no label, non-XML files) and invalid cases (ReferenceFacet, HeaderFacets, CollectionFacet, nested subsections) for both V2 and V4.packages/eslint-plugin-fiori-tools/docs/rules/sap-no-commas-in-section-titles.md: Rule documentation with examples of incorrect and correct patterns and a fix guide.packages/eslint-plugin-fiori-tools/README.md: Added the new rule to the rules table.PR Bot Information
Version:
1.20.37aa2b45e1-a7f0-4004-a7a5-c04372b49508anthropic--claude-4.6-sonnetpull_request.opened