fix: [BAS][Deploy] Password field in the deploy page disappears when the user edits the username.#4934
Merged
Merged
Conversation
…uld be displayed. The previously used flag has other meaning and is misused. * Chnage the behaviour of getOrCreateServiceProvider(). In case the method is called with credentials we always get a fresh provider instance not a cached one. * Fix an issue with the getSystemConfig - the backendTarget is always ignoired since the PromptState.abapDeployConfig is always an object. We return the config in the promot state only if it is a valid one otherwise we return the provided backednTarget.
…redentials prompt appear when the xyz is selected without auth for the second time. This is because both xyz_basic and xyz_noauth represent the same system and use the cached provider for the auth system (xyz_auth). The comparator used to determine the equality of two systems is wrong it disregards the destination. * Fix chageset summary.
🦋 Changeset detectedLatest commit: 93de460 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
avasilev-sap
added
abap-deploy-config-inquirer
generator-adp
avasilev-sap
had a problem deploying
to
ci-secrets
July 13, 2026 07:32 — with 
GitHub Actions
Failure
GitHub Actions
Failure
cianmSAP
approved these changes
Jul 14, 2026
cianmSAP
left a comment
cianmSAP
left a comment
Contributor
There was a problem hiding this comment.
Code updates look ok
Manually tested, appears to work as expected with improvements as described in bug
avasilev-sap
had a problem deploying
to
ci-secrets
July 14, 2026 10:13 — with
GitHub Actions
Failure
GitHub Actions
Failure
nikmace
self-requested a review
July 14, 2026 10:45
nikmace
approved these changes
Jul 14, 2026
nikmace
left a comment
nikmace
left a comment
Contributor
There was a problem hiding this comment.
Changes look good
Changeset is OK
Coverage is good
Did not test manually
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4932
Description
Root Cause
The
showPasswordQuestion()condition was tied totransportConfigNeedsCreds, which gets reset tofalseafter successful log in (so downstream questions like package/transport can appear). This caused the password field to vanish as soon as the username was modified, after authentication completed.Changes
conditions.ts: Introduced a newareCredentialFieldsVisibleflag inPromptState.transportAnswersthat is set when credentials are needed but is not cleared byvalidateCredentials.showPasswordQuestion()now uses this flag instead oftransportConfigNeedsCreds.types.ts: Added theareCredentialFieldsVisibleoptional property to theTransportAnswersinterface.abap-service-provider.ts: RefactoredgetOrCreateServiceProviderto create a new service provider when the same system is called with different credentials (e.g., when the user changes their username). Previously, the cached provider was always reused if the system matched, even with new credentials. Added a privateareCredentialsProvided()helper method and consolidated the provider selection logic.system-utils.ts(new file): Extracted system comparison logic into reusable utilitiesisValidSystemConfigandareSystemConfigEqualswith proper URL normalization (trims whitespace, removes trailing slashes).utils.ts: Removed the now-replacedisSameSystemfunction.Tests: Added/updated unit tests for the new behavior, including scenarios for credential re-entry and system config equality.
Type of change
How have you tested?
system-utils.ts(isValidSystemConfig,areSystemConfigEquals)abap-service-providertests to verify credential-based provider recreation and caching behaviorconditions.test.tsto useareCredentialFieldsVisibleflagChecklist:
The code conforms to the general development principles
Supplied as many details as possible on this change
The code is easy to read and maintainable by others
Corresponding changes to the documentation has been done
Already existing and new unit tests pass locally
🔄 Regenerate and Update Summary
PR Bot Information
Version:
1.27.6pull_request.opened7591e130-7e89-11f1-8304-972930cda22banthropic--claude-4.6-sonnet