Skip to content

Commit e259490

Browse files
committed
[INTERNAL] CI: Add check-engine script and replace --engine-strict
Use check-engine-light to verify that installed dependencies are compatible with the repo's Node.js engine requirement, replacing the previous npm ci --engine-strict approach.
1 parent 93d18fc commit e259490

3 files changed

Lines changed: 28 additions & 2 deletions

File tree

.github/workflows/github-ci.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@ jobs:
2525
node-version: 20.11.0
2626

2727
- name: Install dependencies
28-
run: npm ci --engine-strict # --engine-strict is used to fail-fast if deps require node versions unsupported by the repo
28+
run: npm ci
29+
30+
- name: Check Node.js engine compatibility
31+
run: npm run check-engine
2932

3033
- name: Perform dependencies analysis
3134
run: npm run knip

package-lock.json

Lines changed: 21 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@
4747
"version": "git-chglog --sort semver --next-tag v$npm_package_version -o CHANGELOG.md v4.0.0.. && git add CHANGELOG.md",
4848
"prepublishOnly": "git push --follow-tags",
4949
"release-note": "git-chglog --sort semver -c .chglog/release-config.yml v$npm_package_version",
50-
"knip": "knip --config knip.config.js"
50+
"knip": "knip --config knip.config.js",
51+
"check-engine": "check-engine-light ."
5152
},
5253
"files": [
5354
"CHANGELOG.md",
@@ -141,6 +142,7 @@
141142
"@jridgewell/trace-mapping": "^0.3.31",
142143
"@ui5/project": "^4.0.16",
143144
"ava": "^6.4.1",
145+
"check-engine-light": "0.4.0",
144146
"chokidar-cli": "^3.0.0",
145147
"cross-env": "^10.1.0",
146148
"docdash": "^2.0.2",

0 commit comments

Comments
 (0)