Skip to content

Consider switching float -> int32 for timestamp, lat, lon in SBD52 #26

@lauralindzey

Description

@lauralindzey

(This came up when discussing the SBD55 message definition)

The SBD52 message uses float for some fields that are int32 in later messages; we might want to go back and change this for increased precision.

Example in python:

time.time()
1776472987.8170867
np.float32(time.time())
1776473000.0

It looks like if you serialize timestamps (from the last few years) as a float then deserialize as an int, you'll get a timestamp that's too old to be valid, and that's the check for whether to deserialize as a float instead to maintain backwards compatibility.

I suspect something similar could work for lat/lon, but haven't looked into it in any detail.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions