Feature/gp overlay fix#99
Open
mvicenzi wants to merge 6 commits into
Open
Conversation
Added methods `after()`, `before()`, `overlaps()` and `intersection()`.
Calling `makeTimeInterval()` when reading an interval from the configuration is not required any more, and it is in fact an error. That means this is a BREAKING CHANGE.
The new simulation uses as time reference the trigger data product `shifted`, preventing the accidental use of `daqTrigger` in workflows where there is some already decoded data in the input (a possibility for overlays). If `shifted` is not available, it will silently fall back to configuration defaults.
Contains a comparison object to sort PMT waveforms by channel, then start time.
Unit test designed with GitHub CoPilot help.
…om data products Also a bug fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the PMT overlays algorithm.
This is required by: