Skip to content

Delete Redundant Generators #594

Merged
kjplows merged 3 commits into
developfrom
feature/bearc_fixmultipart
Nov 21, 2025
Merged

Delete Redundant Generators #594
kjplows merged 3 commits into
developfrom
feature/bearc_fixmultipart

Conversation

@bear-is-asleep

Copy link
Copy Markdown
Contributor

Description

The MultiPart and MultiVertex generators have been moved to larsim. Fixes SBNSoftware/sbndcode#835.

Dependent on LArSoft/larsim#162

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • [na] Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@justinjmueller justinjmueller left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this offline. Looks good to me!

@nathanielerowe
nathanielerowe marked this pull request as ready for review November 20, 2025 18:51
@kjplows kjplows moved this from Open pull requests to Testing in SBN software development Nov 20, 2025
@kjplows

kjplows commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02

@kjplows kjplows moved this from Testing to Urgent checks in SBN software development Nov 20, 2025
@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Urgent checks to To merge in SBN software development Nov 21, 2025
@kjplows
kjplows merged commit 92867a7 into develop Nov 21, 2025
@github-project-automation github-project-automation Bot moved this from To merge to Done in SBN software development Nov 21, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Nov 21, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Dec 8, 2025
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@kjplows kjplows added this to the v10_14_00 milestone Jan 16, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in PR archaeology Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done
Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

run_mpvmpr_sbnd*.fcl will not run

4 participants