Renamed sbn::ExtraTriggerInfo::Cryostat::SectorStatus into sectorStatus

Following the standard naming rule.
This is a breaking change. I am not adding a I/O rule because I think no data was produced with the old class.
One can be added at any time.

Author: PetrilloAtWork

sbnobj/Common/Trigger/BeamBits.h

@@ -184,7 +184,7 @@ namespace sbn {
     std::string bitName(triggerType bit);
     /// Returns a mnemonic short name for the trigger window mode.
     std::string bitName(triggerWindowMode bit);
-    /// Returns a mnemonic short name for the trigger window mode.
+    /// Returns a mnemonic short name for the gate type.
     std::string bitName(gateSelection bit);
 
     /// @}

sbnobj/Common/Trigger/ExtraTriggerInfo.cxx

@@ -217,11 +217,11 @@ std::ostream& sbn::operator<< (std::ostream& out, ExtraTriggerInfo const& info)
       << "\n  east wall:  "
       << dumpLVDSmask(cryo.LVDSstatus[ExtraTriggerInfo::EastPMTwall])
       << ", sectors: "
-      << dumpBits(cryo.SectorStatus[ExtraTriggerInfo::EastPMTwall], 6)
+      << dumpBits(cryo.sectorStatus[ExtraTriggerInfo::EastPMTwall], 6)
       << "\n  west wall:  "
       << dumpLVDSmask(cryo.LVDSstatus[ExtraTriggerInfo::WestPMTwall])
       << ", sectors: "
-      << dumpBits(cryo.SectorStatus[ExtraTriggerInfo::WestPMTwall], 6)
+      << dumpBits(cryo.sectorStatus[ExtraTriggerInfo::WestPMTwall], 6)
       ;
   }
 
@@ -235,11 +235,11 @@ std::ostream& sbn::operator<< (std::ostream& out, ExtraTriggerInfo const& info)
       << "\n  east wall:  "
       << dumpLVDSmask(cryo.LVDSstatus[ExtraTriggerInfo::EastPMTwall])
       << ", sectors: "
-      << dumpBits(cryo.SectorStatus[ExtraTriggerInfo::EastPMTwall], 6)
+      << dumpBits(cryo.sectorStatus[ExtraTriggerInfo::EastPMTwall], 6)
       << "\n  west wall:  "
       << dumpLVDSmask(cryo.LVDSstatus[ExtraTriggerInfo::WestPMTwall])
       << ", sectors: "
-      << dumpBits(cryo.SectorStatus[ExtraTriggerInfo::WestPMTwall], 6)
+      << dumpBits(cryo.sectorStatus[ExtraTriggerInfo::WestPMTwall], 6)
       ;
   }
 

sbnobj/Common/Trigger/ExtraTriggerInfo.h

@@ -238,7 +238,7 @@ struct sbn::ExtraTriggerInfo {
      * 
      * The remaining 10 bits are reserved for future use.
      */
-    std::array<std::uint16_t, MaxWalls> SectorStatus { 0U, 0U };
+    std::array<std::uint16_t, MaxWalls> sectorStatus { 0U, 0U };
 
     /// Returns whether there is some recorded LVDS activity.
     constexpr bool hasLVDS() const;
@@ -254,7 +254,7 @@ struct sbn::ExtraTriggerInfo {
 
   /// Bits for the trigger location (see `triggerLocation()`).
   unsigned int triggerLocationBits { 0U };
-  //sbn::triggerLocation triggerLocationBits { sbn::triggerSource::NBits  }
+  
   /// Status of each LVDS channel in each PMT wall at trigger time.
   std::array<CryostatInfo, MaxCryostats> cryostats;
 
@@ -288,7 +288,7 @@ struct sbn::ExtraTriggerInfo {
   /// Returns sector states on a PMT `wall` of the specified `cryostat`.
   /// @throws std::out_of_range if invalid `cryostat` or `wall`
   std::uint16_t SectorInfo(std::size_t cryostat, std::size_t wall) const
-    { return cryostatInfo(cryostat).SectorStatus.at(wall); }
+    { return cryostatInfo(cryostat).sectorStatus.at(wall); }
 
   /// @}
   // --- END ---- Trigger topology ---------------------------------------------
@@ -341,7 +341,7 @@ inline constexpr bool sbn::ExtraTriggerInfo::CryostatInfo::hasLVDS() const {
 inline constexpr bool sbn::ExtraTriggerInfo::CryostatInfo::hasSectors() const {
   // C++20:
   //  return std::ranges::any_of(SectorStatus, std::identity{});
-  for (std::uint64_t bits: SectorStatus) if (bits) return true;
+  for (std::uint64_t bits: sectorStatus) if (bits) return true;
   return false;
 } // sbn::ExtraTriggerInfo::CryostatInfo::hasSectors()
 

sbnobj/Common/Trigger/classes_def.xml

@@ -27,7 +27,8 @@
     <enum name="sbn::bits::triggerSource" ClassVersion="10" />
     <enum name="sbn::bits::triggerLocation" ClassVersion="10" />
     <enum name="sbn::bits::triggerType" ClassVersion="10" />
-    <class name="sbn::ExtraTriggerInfo::CryostatInfo" ClassVersion="11" >
+    <class name="sbn::ExtraTriggerInfo::CryostatInfo" ClassVersion="12" >
+     <version ClassVersion="12" checksum="804951501"/>
      <version ClassVersion="11" checksum="3455337645"/>
      <version ClassVersion="10" checksum="313789291"/>
     </class>