Adding offbeam gate counting in the CAFs#67
Conversation
|
This is a set of PRs that spans SBNSoftware/sbnana#89, SBNSoftware/sbncode#298, and SBNSoftware/sbnanaobj#79 |
| int gates_since_last_trigger; | ||
| bool isBNBOffBeam; | ||
| bool isNuMIOffBeam; | ||
| bool isMajority; |
There was a problem hiding this comment.
"Majority" and "MinBias" are a bit ICARUS jargon-y, could you add a comment after each explaining what they are and/or adopting a more detector agnostic naming nomenclature?
| <version ClassVersion="11" checksum="4062206176"/> | ||
| <version ClassVersion="10" checksum="3057205612"/> | ||
| </class> | ||
| <class name="sbn::EXTCountInfo" ClassVersion="11"> |
There was a problem hiding this comment.
I think @wesketchum complains when people manually change these, but I am not sure why, I defer to him
There was a problem hiding this comment.
@wesketchum is there a procedure for this? I start at 10 and increment from there as I have seen in other examples
There was a problem hiding this comment.
My main issue is to avoid proliferation of the version numbers during development. If data hasn't been written in 'older' versions that needs to be re-read, then we can remove those versions.
So, in this case: if no one has ever made data with 'version 10' that we need to read back, then I'd advocate that we make version 11 --> 10, and 'start' from there. If that's not the case, what you've done is exactly right.
There was a problem hiding this comment.
(or, to this point, if version 12 needs to be kept or not ... if not, can replace 12 with 13, and drop line 16).
|
Once Wes' comment is addressed I am happy |
| <class name="sbn::EXTCountInfo" ClassVersion="13"> | ||
| <version ClassVersion="13" checksum="90106564"/> | ||
| <version ClassVersion="12" checksum="3544499454"/> |
There was a problem hiding this comment.
That would be:
| <class name="sbn::EXTCountInfo" ClassVersion="13"> | |
| <version ClassVersion="13" checksum="90106564"/> | |
| <version ClassVersion="12" checksum="3544499454"/> | |
| <class name="sbn::EXTCountInfo" ClassVersion="12"> | |
| <version ClassVersion="12" checksum="90106564"/> |
Rule of thumb is that a pull request should add at most one version per class.
5 participants
This PR adds offbeam gate counting into the CAFs. The number of gates is computed as a difference with the gate counting performed within the event to compute the number of offbeam gates for BNB or NuMI seen by the trigger hardware on an event-by-event basis.