Skip to content

Fix #2383 - Warning message pops up if analytics is on PCA tab when optimization complete #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akenmorris merged 1 commit into from
Jun 2, 2025
Merged

Fix #2383 - Warning message pops up if analytics is on PCA tab when optimization complete #2384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Libs/Particles/ParticleShapeStatistics.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ class ParticleShapeStatistics {
unsigned int num_samples_group1_;
unsigned int num_samples_group2_;
unsigned int num_samples_;
unsigned int domains_per_shape_;
unsigned int domains_per_shape_ = 0;
unsigned int num_dimensions_;
std::vector<int> group_ids_;

Expand Down
5 changes: 2 additions & 3 deletions Studio/Analysis/AnalysisTool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,9 +1171,6 @@ void AnalysisTool::update_slider() {

//---------------------------------------------------------------------------
void AnalysisTool::reset_stats() {
stats_ready_ = false;
evals_ready_ = false;

ui_->tabWidget->setCurrentWidget(ui_->mean_tab);
ui_->allSamplesRadio->setChecked(true);
ui_->singleSamplesRadio->setChecked(false);
Expand All @@ -1200,6 +1197,8 @@ void AnalysisTool::reset_stats() {
particle_area_panel_->reset();
shape_scalar_panel_->reset();
stats_ = ParticleShapeStatistics();
evals_ready_ = false;
stats_ready_ = false;

ui_->pca_scalar_combo->clear();
if (session_) {
Expand Down
Loading