Try upgrading VTK from 9.1.0 to 9.5.0#2411
Merged
Merged
Conversation
They made a number of changes that alter the output:
Improve accuracy of vtkWindowedSincPolyDataFilter
Using Hamming windowing function resulted in inaccurate scaling of the output
(up to about 1% error, either increase or decrease of the scale).
This commit implements all three window functions that are described in Taubin's paper and adds Nuttal window
and changes the default to Nuttal to eliminate the scaling error.
Note that when passband is set to very small value then shrinkage may occur regardless of the choice of window function.
…f the GHA builders can't find the dep.
https://github.com/AcademySoftwareFoundation/openvdb/pull/1977/files I'm doing the patch instead of upgrading because upgrading requires forcing a new version of GCC which will cascade other dependency upgrades. We may end up doing them, but we need to do this one step at a time and I need the CI/CD working in order to test things.
/Users/runner/miniconda3/envs/shapeworks/include/boost/mpl/aux/integral_wrapper.hpp:73:31: error: integer value -1 is outside the valid range of values [0, 3] for the enumeration type 'int_float_mixtureenum' [-Wenum-constexpr-conversion]
2025-09-01T23:22:49.3891250Z /Users/runner/build/ITK/Modules/ThirdParty/PNG/src/itkpng/pngpriv.h:527:16: fatal error: 'fp.h' file not found 2025-09-01T23:22:49.3992130Z 527 | # include <fp.h> 2025-09-01T23:22:49.4092720Z | ^~~~~~ It seems to be missing now with Clang17
…ror: 2025-09-02T09:23:00.8754420Z /Users/runner/miniconda3/envs/shapeworks/include/boost/mpl/aux_/integral_wrapper.hpp:73:31: error: integer value -1 is outside the valid range of values [0, 3] for the enumeration type 'int_float_mixture_enum' [-Wenum-constexpr-conversion] 2025-09-02T09:23:00.8755440Z /Users/runner/miniconda3/envs/shapeworks/include/boost/mpl/aux_/static_cast.hpp:24:47: note: expanded from macro 'BOOST_MPL_AUX_STATIC_CAST' 2025-09-02T09:23:00.8756050Z 24 | # define BOOST_MPL_AUX_STATIC_CAST(T, expr) static_cast<T>(expr) 2025-09-02T09:23:00.8756400Z | ^ 2025-09-02T09:23:00.8756680Z 2 errors generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.