Skip to content

Test fixes in advance of CRAN push.#300

Merged
pbulsink merged 4 commits into
SCasanova:masterfrom
pbulsink:test-fix
Apr 24, 2026
Merged

Test fixes in advance of CRAN push.#300
pbulsink merged 4 commits into
SCasanova:masterfrom
pbulsink:test-fix

Conversation

@pbulsink
Copy link
Copy Markdown
Collaborator

No description provided.

@pbulsink
Copy link
Copy Markdown
Collaborator Author

Errors in checking FF1 version (pip/uv interaction). Hold for merge testing pending rstudio/reticulate#1890 pushed to CRAN.

@pbulsink pbulsink mentioned this pull request Mar 15, 2026
15 tasks
@pbulsink pbulsink linked an issue Mar 15, 2026 that may be closed by this pull request
@pbulsink pbulsink marked this pull request as draft April 24, 2026 21:09
@pbulsink pbulsink marked this pull request as ready for review April 24, 2026 21:09
Copilot AI review requested due to automatic review settings April 24, 2026 21:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the package’s tests, vignettes, and CI configuration ahead of a CRAN submission, primarily to reflect upstream dependency changes (notably dplyr) and stabilize test behavior.

Changes:

  • Replaced dplyr::case_match() usage in package code and vignettes with dplyr::recode_values().
  • Updated cache-clearing test to call load_schedule() with a fixed season and to check cache entries with arguments.
  • Adjusted CI matrix (drop Python 3.9, add Python 3.14) and refreshed NEWS.md entries/punctuation.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
vignettes/alonso-penalty-2024.Rmd.orig Updates vignette code to use new recoding helper.
vignettes/alonso-penalty-2024.Rmd Same vignette update in the non-.orig source.
tests/testthat/test-clear_f1_cache.R Stabilizes cache test by using season = 2025 and argument-aware cache checks.
R/plotting_style.R Updates marker recoding logic used for plotting styles.
R/plot_fastest.R Updates session-to-title mapping logic for plot_fastest().
NEWS.md Notes refactor away from deprecated case_match() and other maintenance items.
.github/workflows/check-standard.yaml Expands Python test matrix to include 3.14 and removes 3.9.
Comments suppressed due to low confidence (5)

R/plot_fastest.R:97

  • dplyr::recode_values() is likely not an exported dplyr API in commonly supported versions, so this call may fail at runtime. Also consider providing an explicit default fallback so unexpected session values don’t turn race_name into NA and break the plot title.
  if (!(session %in% c("r", "R"))) {
    race_name <- dplyr::recode_values(
      session,
      c("q", "Q") ~ paste0(race_name, " Qualifying"),
      c("s", "S") ~ paste0(race_name, " Sprint"),
      c("fp1", "FP1") ~ paste0(race_name, " FP1"),
      c("fp2", "FP2") ~ paste0(race_name, " FP2"),
      c("fp3", "FP3") ~ paste0(race_name, " FP3")
    )

vignettes/alonso-penalty-2024.Rmd.orig:92

  • dplyr does not export a recode_values() helper (at least in commonly supported versions), so this call is likely to error during vignette build. Consider switching to an exported API such as dplyr::recode()/dplyr::case_when() (or add and use a package-local helper) and, if needed, specify a minimum dplyr version in DESCRIPTION.
  dplyr::mutate(param = dplyr::recode_values(
    param,
    "speed" ~ "Speed (kph)",
    "n_gear" ~ "Gear",
    "throttle" ~ "Throttle %",

vignettes/alonso-penalty-2024.Rmd.orig:128

  • dplyr does not export a recode_values() helper (at least in commonly supported versions), so this call is likely to error during vignette build. Consider switching to an exported API such as dplyr::recode()/dplyr::case_when() (or add and use a package-local helper) and, if needed, specify a minimum dplyr version in DESCRIPTION.
  dplyr::mutate(param = dplyr::recode_values(
    param,
    "speed" ~ "Speed (kph)",
    "n_gear" ~ "Gear",
    "throttle" ~ "Throttle %",

vignettes/alonso-penalty-2024.Rmd:80

  • dplyr does not export a recode_values() helper (at least in commonly supported versions), so this call is likely to error during vignette build. Consider switching to an exported API such as dplyr::recode()/dplyr::case_when() (or add and use a package-local helper) and, if needed, specify a minimum dplyr version in DESCRIPTION.
  dplyr::mutate(param = dplyr::recode_values(
    param,
    "speed" ~ "Speed (kph)",
    "n_gear" ~ "Gear",
    "throttle" ~ "Throttle %",

vignettes/alonso-penalty-2024.Rmd:124

  • dplyr does not export a recode_values() helper (at least in commonly supported versions), so this call is likely to error during vignette build. Consider switching to an exported API such as dplyr::recode()/dplyr::case_when() (or add and use a package-local helper) and, if needed, specify a minimum dplyr version in DESCRIPTION.
  dplyr::mutate(param = dplyr::recode_values(
    param,
    "speed" ~ "Speed (kph)",
    "n_gear" ~ "Gear",
    "throttle" ~ "Throttle %",

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread R/plotting_style.R
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.88%. Comparing base (9ff24fc) to head (66db130).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
- Coverage   94.33%   92.88%   -1.46%     
==========================================
  Files          20       20              
  Lines         971     1082     +111     
==========================================
+ Hits          916     1005      +89     
- Misses         55       77      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pbulsink pbulsink merged commit 8cc16ae into SCasanova:master Apr 24, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Noting auto-check failures

2 participants