Skip to content

feat: support nested field paths in field filtering#4478

Open
lisahaase-sdase wants to merge 6 commits into
mainfrom
feat/nested_fields
Open

feat: support nested field paths in field filtering#4478
lisahaase-sdase wants to merge 6 commits into
mainfrom
feat/nested_fields

Conversation

@lisahaase-sdase

Copy link
Copy Markdown
Contributor

No description provided.

@lisahaase-sdase lisahaase-sdase requested a review from a team as a code owner June 25, 2026 07:24
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor
Next minor release will be 9.3.0, Show Release Notes

9.3.0 (2026-07-10)

Features

  • only enable field filter in nested paths if flag is true (eb32528)
  • support nested field paths in field filtering (51f71e1)

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Test Results

1 212 files  ± 0  1 212 suites  ±0   1h 22m 49s ⏱️ - 4m 19s
1 546 tests + 2  1 532 ✅ + 2  14 💤 ±0  0 ❌ ±0 
6 548 runs  +20  6 486 ✅ +20  62 💤 ±0  0 ❌ ±0 

Results for commit eb32528. ± Comparison against base commit b0cbea6.

This pull request removes 4 and adds 6 tests. Note that renamed tests count towards both.
org.sdase.commons.server.dropwizard.metadata.MetadataContextMergeIntegrationTest ‑ [4] {tenant-id=[t-c], processes=[p-c1, p-c2]}, {tenant-id=[], processes=[p-n3, p-n4]}, EXTEND, {tenant-id=[t-c], processes=[p-c1, p-c2, p-n3, p-n4]}
org.sdase.commons.server.dropwizard.metadata.MetadataContextMergeIntegrationTest ‑ [5] {tenant-id=[t-c]}, {processes=[p-n]}, EXTEND, {tenant-id=[t-c], processes=[p-n]}
org.sdase.commons.server.dropwizard.metadata.MetadataContextMergeIntegrationTest ‑ [8] {tenant-id=[t-c]}, {tenant-id=[t-n], processes=[p-n]}, KEEP, {tenant-id=[t-c], processes=[p-n]}
org.sdase.commons.server.dropwizard.metadata.MetadataContextMergeIntegrationTest ‑ [9] {tenant-id=[t-c], processes=[p-c]}, {tenant-id=[t-n]}, REPLACE, {tenant-id=[t-n], processes=[p-c]}
org.sdase.commons.server.jackson.JacksonConfigurationBundleIT ‑ shouldFilterChildrenAndNestedFieldsByPathIfFlagIsTrue()
org.sdase.commons.server.jackson.JacksonConfigurationBundleIT ‑ shouldKeepExcludedNestedFieldAsNullInDefaultMode()
org.sdase.commons.server.jackson.JacksonConfigurationBundleIT ‑ shouldKeepFullSubtreeForNestedAnnotatedChildByDefault()
org.sdase.commons.server.jackson.JacksonConfigurationBundleIT ‑ shouldKeepFullSubtreeForParentPathsFromRepeatedFieldParams()
org.sdase.commons.server.jackson.JacksonConfigurationBundleIT ‑ shouldKeepFullSubtreeForUnannotatedChildEvenIfSubFieldIsRequested()
org.sdase.commons.server.kafka.producer.MetadataContextAwareKafkaProducerTest ‑ [4] {tenant-id=[t1]}, {something=great}, {something=[great], tenant-id=[t1]}

♻️ This comment has been updated with latest results.

@YellowFlora YellowFlora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NTH: add regression test for nested object without @EnableFieldFilter to pin compatibility behavior.

MUST: document that nested field paths are only applied inside nested object types annotated with @EnableFieldFilter; otherwise selecting a nested field keeps the whole nested object.

MUST: fix Sonar issues.

@lisahaase-sdase lisahaase-sdase force-pushed the feat/nested_fields branch 3 times, most recently from 225071d to b4dcc50 Compare July 6, 2026 07:16
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants