fix(updates): preserve legacy mac app path

Author: SDSLeon

src/main/macAppPathMigration.test.ts

@@ -0,0 +1,95 @@
+import { lstatSync, mkdirSync, mkdtempSync, readlinkSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { afterEach, beforeEach, describe, expect, it } from "vitest";
+import { repairLegacyMacAppPath } from "./macAppPathMigration";
+
+describe("repairLegacyMacAppPath", () => {
+  let root: string;
+
+  beforeEach(() => {
+    root = mkdtempSync(join(tmpdir(), "poracode-mac-app-path-"));
+  });
+
+  afterEach(() => {
+    rmSync(root, { recursive: true, force: true });
+  });
+
+  function packagedExecutable(appName: string): string {
+    const executablePath = join(root, appName, "Contents", "MacOS", appName.replace(/\.app$/u, ""));
+    mkdirSync(join(root, appName, "Contents", "MacOS"), { recursive: true });
+    writeFileSync(executablePath, "executable");
+    return executablePath;
+  }
+
+  it("restores the legacy Nightly path as a relative symlink", () => {
+    const executablePath = packagedExecutable("Poracode Nightly.app");
+
+    expect(
+      repairLegacyMacAppPath("nightly", {
+        platform: "darwin",
+        isPackaged: true,
+        executablePath,
+      }),
+    ).toBe("created");
+
+    const legacyPath = join(root, "Lightcode Nightly.app");
+    expect(lstatSync(legacyPath).isSymbolicLink()).toBe(true);
+    expect(readlinkSync(legacyPath)).toBe("Poracode Nightly.app");
+  });
+
+  it("restores the legacy Stable path", () => {
+    const executablePath = packagedExecutable("Poracode.app");
+
+    expect(
+      repairLegacyMacAppPath("stable", {
+        platform: "darwin",
+        isPackaged: true,
+        executablePath,
+      }),
+    ).toBe("created");
+    expect(readlinkSync(join(root, "Lightcode.app"))).toBe("Poracode.app");
+  });
+
+  it("never replaces an existing legacy app", () => {
+    const executablePath = packagedExecutable("Poracode Nightly.app");
+    const legacyPath = join(root, "Lightcode Nightly.app");
+    mkdirSync(legacyPath);
+
+    expect(
+      repairLegacyMacAppPath("nightly", {
+        platform: "darwin",
+        isPackaged: true,
+        executablePath,
+      }),
+    ).toBe("skipped");
+    expect(lstatSync(legacyPath).isDirectory()).toBe(true);
+  });
+
+  it("skips unpackaged, non-macOS, and unexpectedly named bundles", () => {
+    const executablePath = packagedExecutable("Poracode Nightly.app");
+    const otherExecutablePath = packagedExecutable("Renamed.app");
+
+    expect(
+      repairLegacyMacAppPath("nightly", {
+        platform: "linux",
+        isPackaged: true,
+        executablePath,
+      }),
+    ).toBe("skipped");
+    expect(
+      repairLegacyMacAppPath("nightly", {
+        platform: "darwin",
+        isPackaged: false,
+        executablePath,
+      }),
+    ).toBe("skipped");
+    expect(
+      repairLegacyMacAppPath("nightly", {
+        platform: "darwin",
+        isPackaged: true,
+        executablePath: otherExecutablePath,
+      }),
+    ).toBe("skipped");
+  });
+});

src/main/macAppPathMigration.ts

@@ -0,0 +1,63 @@
+import { lstatSync, realpathSync, symlinkSync } from "node:fs";
+import { basename, dirname, join } from "node:path";
+import type { PoracodeChannel } from "@/shared/channel";
+
+interface MacAppPathMigrationOptions {
+  platform?: NodeJS.Platform;
+  isPackaged?: boolean;
+  executablePath?: string;
+}
+
+type MacAppPathMigrationResult = "created" | "skipped" | "failed";
+
+function appNamesFor(channel: PoracodeChannel): { current: string; legacy: string } {
+  return channel === "nightly"
+    ? { current: "Poracode Nightly.app", legacy: "Lightcode Nightly.app" }
+    : { current: "Poracode.app", legacy: "Lightcode.app" };
+}
+
+function bundlePathFromExecutable(executablePath: string): string {
+  return dirname(dirname(dirname(executablePath)));
+}
+
+/**
+ * Keep the pre-rebrand application path usable after Squirrel renames the
+ * installed bundle. macOS Dock items retain that path, so removing it leaves a
+ * dead tile even though the renamed Poracode bundle launches normally.
+ *
+ * The relative symlink is deliberately best-effort and never replaces an
+ * existing file. Squirrel resolves the running application's canonical path
+ * before preparing later updates, so installs continue targeting Poracode.
+ */
+export function repairLegacyMacAppPath(
+  channel: PoracodeChannel,
+  options: MacAppPathMigrationOptions = {},
+): MacAppPathMigrationResult {
+  const platform = options.platform ?? process.platform;
+  const isPackaged = options.isPackaged ?? false;
+  if (platform !== "darwin" || !isPackaged) return "skipped";
+
+  try {
+    const executablePath = realpathSync(options.executablePath ?? process.execPath);
+    const currentBundlePath = bundlePathFromExecutable(executablePath);
+    const names = appNamesFor(channel);
+    if (basename(currentBundlePath) !== names.current) return "skipped";
+
+    const legacyBundlePath = join(dirname(currentBundlePath), names.legacy);
+    try {
+      lstatSync(legacyBundlePath);
+      return "skipped";
+    } catch (error) {
+      if ((error as NodeJS.ErrnoException).code !== "ENOENT") throw error;
+    }
+
+    symlinkSync(names.current, legacyBundlePath, "dir");
+    console.info(`[poracode] restored legacy macOS app path at ${legacyBundlePath}`);
+    return "created";
+  } catch (error) {
+    // The app remains launchable from its canonical Poracode path if the
+    // install directory is read-only or a filesystem policy rejects symlinks.
+    console.warn("[poracode] failed to restore legacy macOS app path", error);
+    return "failed";
+  }
+}

src/main/main.ts

@@ -85,6 +85,7 @@ import {
 import { AppControlsMcpIngress } from "./app-controls";
 import { legacyProductNameFor, resolveLegacyElectronUserDataDir } from "./legacyDataMigration";
 import { refreshMacDockIcon } from "./macDockIcon";
+import { repairLegacyMacAppPath } from "./macAppPathMigration";
 
 const isDev = Boolean(process.env.VITE_DEV_SERVER_URL);
 const channel = resolvePoracodeChannel();
@@ -561,6 +562,7 @@ if (!hasSingleInstanceLock) {
     .whenReady()
     .then(async () => {
       if (preserveLegacySafeStorageIdentity) app.setName(productNameFor(channel));
+      repairLegacyMacAppPath(channel, { isPackaged: app.isPackaged });
       refreshMacDockIcon();
       Menu.setApplicationMenu(null);