feat(acp): add auth-required dock, elicitation handling, and generic ACP provider UI

- add ThreadAuthRequiredDock and acpRegistryAuth helpers for env-var/agent-owned auth flows
- introduce acpGeneric renderer provider and register composer controls
- extend ACP session/probe/mapping to support elicitation requests and model descriptions
- share questionAnswers decoder across claude, opencode, and acp providers
- surface model descriptions as secondary hints in ProviderModelMenu
- bump @agentclientprotocol/sdk to ^0.21.1 and harden Windows build script

Author: SDSLeon

.github/workflows/_build.yml

@@ -108,14 +108,14 @@ jobs:
         run: |
           if [ "${{ matrix.os }}" = "windows-latest" ]; then
             pnpm run prepare:package-assets
-            pnpm exec electron-builder --win
+            pnpm exec electron-builder --config electron-builder.config.cjs --win
           else
             if [ "${{ matrix.os }}" = "macos-latest" ]; then
               pnpm run prepare:agent-plugins
-              pnpm exec electron-builder --mac
+              pnpm exec electron-builder --config electron-builder.config.cjs --mac
             else
               pnpm run prepare:package-assets
-              pnpm exec electron-builder --linux
+              pnpm exec electron-builder --config electron-builder.config.cjs --linux
             fi
           fi
         shell: bash

package.json

@@ -51,7 +51,7 @@
     "prepare": "husky"
   },
   "dependencies": {
-    "@agentclientprotocol/sdk": "^0.21.0",
+    "@agentclientprotocol/sdk": "^0.21.1",
     "@anthropic-ai/claude-agent-sdk": "^0.3.142",
     "@chenglou/pretext": "^0.0.6",
     "@dnd-kit/abstract": "^0.4.0",

pnpm-lock.yaml

@@ -7,7 +7,7 @@
 // by glob is a moving target. Instead we copy the build artifacts into a clean
 // staging directory, write a fresh package.json that lists ONLY the runtime
 // externals reported by `scripts/scan-runtime-externals.mjs`, run a flat
-// `npm install`, and run electron-builder there.
+// `pnpm install` (node-linker=hoisted), and run electron-builder there.
 
 import { spawnSync } from "node:child_process";
 import {
@@ -106,10 +106,10 @@ function detectHostPlatform() {
 
 const PLATFORM_FLAG = { mac: "--mac", linux: "--linux", win: "--win" };
 
-// npm doesn't auto-install peer deps in every situation, and a missing peer
-// of a runtime external surfaces as `ERR_MODULE_NOT_FOUND` deep inside SDK
-// code at app launch. Walk each external's installed package.json and pull
-// in any non-optional peer that the root itself declares as a dep.
+// A missing peer of a runtime external surfaces as `ERR_MODULE_NOT_FOUND` deep
+// inside SDK code at app launch. Walk each external's installed package.json
+// and pull in any non-optional peer that the root itself declares as a dep —
+// this stays explicit regardless of the installer's auto-peer behavior.
 function expandPeerDeps(externals, rootPkg) {
   const expanded = new Set();
   const rootHasDep = (name) =>
@@ -187,7 +187,7 @@ function copyDir(from, to) {
 // electron-builder.yml keeps them out of the shipped app; this prune shrinks
 // the stage tmpdir and speeds up electron-builder's file walk.
 //
-// Safe to delete after `npm install` returned: the platform packs are pure
+// Safe to delete after `pnpm install` returned: the platform packs are pure
 // binary blobs with no postinstall hooks, and the SDK only `require`s them
 // lazily at runtime (when `pathToClaudeCodeExecutable` is unset) — which we
 // always set on posix and route through wsl.exe on WSL.
@@ -272,15 +272,23 @@ async function main() {
     writeFileSync(join(stageRoot, "electron-builder.yml"), buildElectronBuilderConfig());
 
     // 6. Install prod + stage devdeps with a flat layout.
-    //    We DON'T use --omit=optional because electron-builder's dmg-builder
+    //    node-linker=hoisted makes pnpm produce an npm-style flat node_modules,
+    //    which electron-builder's file walker (and our asar globs) expect.
+    //    dangerously-allow-all-builds bypasses pnpm 10+'s build-script gating
+    //    (electron's postinstall must run to download the binary; better-sqlite3
+    //    and node-pty compile native bindings). The stage's deps are pinned to
+    //    versions the root project already trusts, so this is no riskier than
+    //    `pnpm install` on the root.
+    //    We DON'T disable optionals because electron-builder's dmg-builder
     //    requires the `dmg-license` optionalDependency unconditionally at
     //    import time. Instead we install optionals normally, then surgically
     //    delete the only optional we actually want gone: the Claude SDK's
     //    platform-specific `claude` SEA binary (~200 MB).
-    //    --no-package-lock keeps the stage stateless across runs.
+    //    The stage tmpdir is fresh each run, so any generated pnpm-lock.yaml
+    //    is ephemeral and gets discarded with the stage.
     run(
-      "npm",
-      ["install", "--no-package-lock", "--no-fund", "--no-audit", "--ignore-scripts=false"],
+      "pnpm",
+      ["install", "--config.node-linker=hoisted", "--config.dangerously-allow-all-builds=true"],
       { cwd: stageRoot },
     );
 

scripts/build-desktop-artifact.mjs

@@ -144,6 +144,81 @@ describe("ProviderModelMenu", () => {
     expect(await screen.findByText("Model 500")).toBeInTheDocument();
   });
 
+  it("renders normalized model rate descriptions as muted row hints", async () => {
+    const provider = makeProvider(1);
+    provider.capabilities.models = [
+      {
+        id: "opus",
+        label: "Opus",
+        description: "2x",
+      },
+    ];
+
+    render(
+      <ProviderModelMenu
+        providers={[provider]}
+        currentAgentKind="codex"
+        currentModel="opus"
+        onChange={vi.fn<(next: { agentKind: string; model: string }) => void>()}
+      />,
+    );
+
+    fireEvent.click(screen.getByRole("button", { name: "Select model" }));
+
+    expect(await screen.findByRole("option", { name: /Opus/u })).toHaveTextContent("· 2x");
+  });
+
+  it("ignores provider prose model descriptions", async () => {
+    const provider = makeProvider(1);
+    provider.capabilities.models = [
+      {
+        id: "opus",
+        label: "Opus",
+        description: "2x Factory token rate",
+      },
+    ];
+
+    render(
+      <ProviderModelMenu
+        providers={[provider]}
+        currentAgentKind="codex"
+        currentModel="opus"
+        onChange={vi.fn<(next: { agentKind: string; model: string }) => void>()}
+      />,
+    );
+
+    fireEvent.click(screen.getByRole("button", { name: "Select model" }));
+
+    expect(await screen.findByRole("option", { name: /Opus/u })).toHaveTextContent("Opus");
+    expect(screen.getByRole("option", { name: /Opus/u })).not.toHaveTextContent("Factory");
+  });
+
+  it("keeps raw model descriptions available without rendering them in the row", async () => {
+    const provider = makeProvider(1);
+    provider.capabilities.models = [
+      {
+        id: "opus",
+        label: "Opus",
+        description: "2x",
+        tooltipDescription: "2x Factory token rate",
+      },
+    ];
+
+    render(
+      <ProviderModelMenu
+        providers={[provider]}
+        currentAgentKind="codex"
+        currentModel="opus"
+        onChange={vi.fn<(next: { agentKind: string; model: string }) => void>()}
+      />,
+    );
+
+    fireEvent.click(screen.getByRole("button", { name: "Select model" }));
+    const row = await screen.findByRole("option", { name: /Opus/u });
+    expect(row).toHaveTextContent("· 2x");
+    expect(screen.queryByText("2x Factory token rate")).not.toBeInTheDocument();
+  });
+
   it("keeps the current provider header rendered while scrolling deep into a long section", async () => {
     render(
       <ProviderModelMenu

src/renderer/components/common/ProviderModelMenu/ProviderModelMenu.test.tsx

@@ -27,6 +27,7 @@ const MODEL_MENU_ROW_HEIGHT = 28;
 const MODEL_MENU_PROVIDER_HEADER_BOTTOM_GAP = 4;
 const MODEL_MENU_MAX_HEIGHT = 288;
 const MODEL_MENU_OVERSCAN_ROWS = 16;
+const MODEL_DESCRIPTION_TOOLTIP_DELAY_MS = 1000;
 
 interface WindowedItemsMeta {
   structureKey: string;
@@ -667,8 +668,8 @@ function WindowedProviderModelList(props: {
               // the label string itself (e.g. "GPT-5.5 · 272K · Medium").
               // Render the head as the model name and the tail as muted hint.
               const { name, hint } = splitModelLabel(item.label);
-              const mutedHint = hint ?? item.contextDescription;
-              return (
+              const mutedHint = [hint, item.contextDescription].filter(Boolean).join(" · ");
+              const content = (
                 <span className="flex min-w-0 flex-1 items-center gap-1.5">
                   <span className="min-w-0 truncate">{name}</span>
                   {mutedHint ? (
@@ -678,6 +679,19 @@ function WindowedProviderModelList(props: {
                   ) : null}
                 </span>
               );
+              return item.tooltipDescription ? (
+                <Tooltip delay={MODEL_DESCRIPTION_TOOLTIP_DELAY_MS}>
+                  {content}
+                  <Tooltip.Content
+                    placement="right"
+                    className="max-w-72 whitespace-normal break-words text-xs"
+                  >
+                    {item.tooltipDescription}
+                  </Tooltip.Content>
+                </Tooltip>
+              ) : (
+                content
+              );
             })()}
             {item.showProviderIcon || item.subProviderLabel ? (
               <span className="ml-auto flex min-w-0 shrink-0 items-center gap-1 text-muted/70">