Skip to content

Commit d6aae9b

Browse files
SDSLeonclaude
andcommitted
ci(release): skip Windows code signing
Drop the NuGet provider install, Azure secrets wiring, and the `--config build/signing.yml` arg on Windows. Signing is not configured yet; building unsigned avoids the runner-side NuGet bootstrap failure and keeps the release job green until signing is set up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 71daadb commit d6aae9b

1 file changed

Lines changed: 1 addition & 27 deletions

File tree

.github/workflows/release.yml

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -109,19 +109,6 @@ jobs:
109109
- name: Install dependencies
110110
run: pnpm install --frozen-lockfile
111111

112-
- name: Install NuGet provider (Windows signing)
113-
if: matrix.os == 'windows-latest'
114-
shell: pwsh
115-
env:
116-
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
117-
run: |
118-
if (-not $env:AZURE_TENANT_ID) {
119-
Write-Host "AZURE_TENANT_ID not set; skipping NuGet provider installation."
120-
exit 0
121-
}
122-
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
123-
Install-PackageProvider -Name NuGet -MinimumVersion 2.8.5.201 -Force -Scope CurrentUser
124-
125112
- name: Build app
126113
run: pnpm run build
127114
shell: bash
@@ -157,12 +144,7 @@ jobs:
157144
run: |
158145
if [ "${{ matrix.os }}" = "windows-latest" ]; then
159146
pnpm run prepare:package-assets
160-
if [ -n "$AZURE_TENANT_ID" ]; then
161-
pnpm exec electron-builder --win --config electron-builder.yml --config build/signing.yml
162-
else
163-
echo "Azure signing secrets not configured; building unsigned Windows installer."
164-
pnpm exec electron-builder --win
165-
fi
147+
pnpm exec electron-builder --win
166148
else
167149
if [ "${{ matrix.os }}" = "macos-latest" ]; then
168150
pnpm run prepare:agent-plugins
@@ -175,14 +157,6 @@ jobs:
175157
shell: bash
176158
env:
177159
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
178-
# Azure Trusted Signing (Windows only)
179-
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
180-
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
181-
AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
182-
AZURE_SIGNING_PUBLISHER_NAME: ${{ secrets.AZURE_SIGNING_PUBLISHER_NAME }}
183-
AZURE_SIGNING_ENDPOINT: ${{ secrets.AZURE_SIGNING_ENDPOINT }}
184-
AZURE_SIGNING_ACCOUNT_NAME: ${{ secrets.AZURE_SIGNING_ACCOUNT_NAME }}
185-
AZURE_SIGNING_CERT_PROFILE: ${{ secrets.AZURE_SIGNING_CERT_PROFILE }}
186160

187161
- name: Upload built artifacts
188162
uses: actions/upload-artifact@v7

0 commit comments

Comments
 (0)