feat(skills): Skills manager — per-project & global, marketplace, optimizer#239
Open
SDSLeon wants to merge 1 commit into
Open
feat(skills): Skills manager — per-project & global, marketplace, optimizer#239SDSLeon wants to merge 1 commit into
SDSLeon wants to merge 1 commit into
Conversation
- Add shared skills domain: contracts, scope/root conventions, IPC procedures - Implement supervisor SkillsService for scan/read/write/create/delete/rename/transfer plus tests - Add SkillsManager UI with editor, marketplace, and optimizer modals - Wire Skills sections into project and global settings overlays - Allow absolute paths outside project root in local file handlers
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a unified Skills manager surfaced in both global Settings → Skills and per-project Settings → Skills. A skill is a folder with a
SKILL.md(YAML frontmattername/description/metadata+ markdown). Skills live in scopes = level (global~vs project repo root) × root (claude→.claude/skills,agents→.agents/skills— the shared folder read by Copilot, Codex, Cursor, Gemini, Grok, OpenCode).One reusable
SkillsManagerpowers both surfaces:SKILL.md), rename (folder), delete, and copy/move between scopes/providers..agents, some read their own folder). Content-fingerprinted and divergence-aware; newest edit wins; preview-before-apply.How it works
src/shared/contracts/skills.ts(zod payloads + result types),src/shared/skills.ts(SKILL_ROOTS, marketplace catalog,buildSkillMarkdown).scanSkills,readSkill,writeSkill,createSkill,renameSkill,deleteSkill,transferSkill,optimizeSkills,installMarketplaceSkill,installSkillFromGit,revealSkill).src/supervisor/skills.ts(SkillsService) does the filesystem work with path-traversal guards that refuse to operate outside a skills directory.src/renderer/components/skills/(manager + editor/marketplace/optimizer modals +useSkillshook), mounted via thin wrappers in both settings overlays.Hardening (from an adversarial multi-agent review)
name/descriptionso colons/quotes don't corrupt frontmatter for strict YAML parsers.SKILL.md) folders, and excludes unreadable roots so it never clobbers them.readSkillguarded; git install hardened (--separator, no-prompt env,--single-branch --no-tags,sourcePathtraversal guard, slugified folder name); symlink-dereferencing copies.metadata.source) and auto-uniquifies install names; reveal hidden for not-yet-created scopes; unresolved project shows a message instead of degrading silently.Known limitations (deliberately deferred)
writeExternalFile/listProjectTreeIPC trust model) rather than anchoring to home/project root.Testing
tsgotypecheck,oxlint,oxfmtall clean.🤖 Generated with Claude Code