Skip to content

Complete Salesforce Settings Migration#57

Merged
axelstudios merged 1 commit into
mainfrom
add-salesforce-mappings
Mar 31, 2026
Merged

Complete Salesforce Settings Migration#57
axelstudios merged 1 commit into
mainfrom
add-salesforce-mappings

Conversation

@kflemin
Copy link
Copy Markdown
Contributor

@kflemin kflemin commented Mar 27, 2026

Finishes migrating the Salesforce integration settings from the original AngularJS front-end, fixing several bugs and
adding missing functionality.

Bug Fixes

  • Toggle visibility — Disabling the "Salesforce Integration" toggle now hides all config sections below it (matching
    original AngularJS ng-if behavior). Controls are also properly disabled on initial load.
  • Data Administrator Name Column — was bound to data_admin_account_name_column (duplicate); corrected to
    data_admin_name_column.
  • Data Administrator Contact Field — was bound to default_data_admin_account_name (duplicate); corrected to
    data_admin_contact_fieldname.
  • SalesforceMapping.column type — was typed as literal 10; corrected to number.
  • SalesforceService — removed leftover console.log; replaced generic "Error fetching organization" messages with
    context-specific error strings.

New Features

  • Benchmark Configuration section — 5 form fields that existed in the TypeScript FormGroup but were never rendered:
    Unique Benchmark ID Fieldname, SEED Unique Benchmark ID Column, Cycle Name Benchmark Field, Status Label Benchmark Field,
    All Labels Benchmark Field.
  • Test Connection feedback — inline success/error panel displayed after testing the Salesforce connection.

UI Improvements

  • Hour and Minute schedule fields stacked vertically so hint text isn't truncated.

@kflemin kflemin requested a review from axelstudios March 27, 2026 18:51
@kflemin kflemin mentioned this pull request Mar 29, 2026
@axelstudios axelstudios merged commit 3391cc1 into main Mar 31, 2026
2 checks passed
@axelstudios axelstudios deleted the add-salesforce-mappings branch March 31, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants