Update summary endpoint to return total GFA#5234
Open
kflemin wants to merge 6 commits into
Open
Conversation
kflemin
added
the
Enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the v4 analyses stats endpoint to include a “Total GFA”/total square footage value so the inventory summary page can display it, aligning v4 behavior with v3.
Changes:
- Query
PropertyState.gross_floor_areafor the selected cycle’s property states. - Compute and return a new
total_sqftfield in the v4/analyses/statsresponse.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
73
to
77
| "status": "success", | ||
| "total_records": len(state_ids), | ||
| "number_extra_data_fields": len(extra_data_columns), | ||
| "total_sqft": total_sqft, | ||
| "stats": stats, |
Contributor
Author
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Implemented in b4a92ce. I updated seed/tests/v4/test_analyses_views.py::test_stats to use deterministic gross_floor_area fixture values and added an assertion that verifies total_sqft equals the expected summed value.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SEED-platform/seed/sessions/2d4b322c-d08f-4680-839c-57b8c167bec5 Co-authored-by: kflemin <2205659+kflemin@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SEED-platform/seed/sessions/2d4b322c-d08f-4680-839c-57b8c167bec5 Co-authored-by: kflemin <2205659+kflemin@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SEED-platform/seed/sessions/2d4b322c-d08f-4680-839c-57b8c167bec5 Co-authored-by: kflemin <2205659+kflemin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v3 version of the endpoint was updated with Total GFA calculation to display on the inventory summary page. v4 did not yet have that calculation