@@ -134,9 +134,9 @@ const ShareSelectRow: React.FC<RowProps> = ({
134134 } }
135135 to = { getAccountLink ( account . group_id , account . type , account . id ) }
136136 >
137- < Grid container direction = "row" alignItems = "center" >
137+ < Grid container direction = "row" sx = { { alignItems : "center" } } >
138138 < Grid > { getAccountIcon ( account . type ) } </ Grid >
139- < Grid display = "flex" flexDirection = "column" sx = { { ml : 1 } } >
139+ < Grid sx = { { display : "flex" , flexDirection : "column" , ml : 1 } } >
140140 < Typography variant = "body2" component = "span" >
141141 { account . name }
142142 </ Typography >
@@ -239,22 +239,22 @@ export const ShareSelect: React.FC<ShareSelectProps> = ({
239239 }
240240 return true ;
241241 } )
242- . sort ( sortFn ) ;
243- } , [ value , showEvents , editable , searchValue , unfilteredAccounts , shouldDisplayAccount ] ) ;
242+ . toSorted ( sortFn ) ;
243+ } , [ value , showEvents , editable , searchValue , unfilteredAccounts , shouldDisplayAccount , hideShowEventsFilter ] ) ;
244244
245245 React . useEffect ( ( ) => {
246246 // set displayed split mode to evenly if we have a "shares" split with non-even shares
247247 if (
248248 splitMode === "shares" &&
249- Object . values ( value ) . reduce ( ( onlyDefaultShares , value ) => onlyDefaultShares && value === 1 , true ) &&
249+ Object . values ( value ) . reduce ( ( onlyDefaultShares , val ) => onlyDefaultShares && val === 1 , true ) &&
250250 ( communistShares == null || communistShares === 1 || communistShares === 0 )
251251 ) {
252252 setFrontendSplitMode ( "evenly" ) ;
253253 }
254- } , [ splitMode , value , setFrontendSplitMode ] ) ;
254+ } , [ splitMode , value , setFrontendSplitMode , communistShares ] ) ;
255255
256256 const { nSelectedPeople, nSelectedEvents } = React . useMemo ( ( ) => {
257- const nSelectedPeople = accounts . reduce ( ( nAccs : number , acc : Account ) => {
257+ const selectedPeople = accounts . reduce ( ( nAccs : number , acc : Account ) => {
258258 if ( acc . type !== "personal" ) {
259259 return nAccs ;
260260 }
@@ -263,7 +263,7 @@ export const ShareSelect: React.FC<ShareSelectProps> = ({
263263 }
264264 return nAccs ;
265265 } , 0 ) ;
266- const nSelectedEvents = accounts . reduce ( ( nAccs : number , acc : Account ) => {
266+ const selectedEvents = accounts . reduce ( ( nAccs : number , acc : Account ) => {
267267 if ( acc . type !== "clearing" ) {
268268 return nAccs ;
269269 }
@@ -273,11 +273,11 @@ export const ShareSelect: React.FC<ShareSelectProps> = ({
273273 return nAccs ;
274274 } , 0 ) ;
275275
276- return { nSelectedPeople, nSelectedEvents } ;
277- } , [ unfilteredAccounts , value , shouldDisplayAccount ] ) ;
276+ return { nSelectedPeople : selectedPeople , nSelectedEvents : selectedEvents } ;
277+ } , [ value , accounts ] ) ;
278278
279279 const nSelected = React . useMemo ( ( ) => {
280- return Object . values ( value ) . reduce ( ( nSelected , val ) => nSelected + ( val > 0 ? 1 : 0 ) , 0 ) ;
280+ return Object . values ( value ) . reduce ( ( selected , val ) => selected + ( val > 0 ? 1 : 0 ) , 0 ) ;
281281 } , [ value ] ) ;
282282 const isAllSelected = nSelected === accounts . length ;
283283 const showSearch = ! isSmallScreen && unfilteredAccounts . length > 5 ;
@@ -307,7 +307,7 @@ export const ShareSelect: React.FC<ShareSelectProps> = ({
307307
308308 return (
309309 < div >
310- < Grid container direction = { isSmallScreen ? "column" : "row" } justifyContent = "space-between" >
310+ < Stack direction = { isSmallScreen ? "column" : "row" } sx = { { justifyContent : "space-between" } } >
311311 < Stack direction = "row" spacing = { 1 } sx = { { alignItems : "center" , marginY : 1 } } >
312312 < Typography variant = "subtitle1" > { label } </ Typography >
313313 { nSelectedPeople > 0 && (
@@ -351,12 +351,14 @@ export const ShareSelect: React.FC<ShareSelectProps> = ({
351351 select
352352 >
353353 { allowedSplitModes . map ( ( mode ) => (
354- < MenuItem value = { mode } > { t ( `shareSelect.split_${ mode } ` ) } </ MenuItem >
354+ < MenuItem key = { mode } value = { mode } >
355+ { t ( `shareSelect.split_${ mode } ` ) }
356+ </ MenuItem >
355357 ) ) }
356358 </ TextField >
357359 </ Stack >
358360 ) }
359- </ Grid >
361+ </ Stack >
360362 { communistShares != null &&
361363 ( frontendSplitMode === "evenly" ? (
362364 < FormControlLabel
0 commit comments