Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions apps/web/src/pages/accounts/AccountDetail/AccountDetail.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ import { AccountTransactionList } from "@/pages/accounts/AccountDetail/AccountTr
import { BalanceHistoryGraph } from "@/pages/accounts/AccountDetail/BalanceHistoryGraph";
import { ClearingAccountDetail } from "@/pages/accounts/AccountDetail/ClearingAccountDetail";
import { MobilePaper } from "@/components/style";
import { Loading } from "@abrechnung/components";
import { useQuery, useTitle } from "@/core/utils";
import { useTitle } from "@/core/utils";
import { Grid, Typography } from "@mui/material";
import * as React from "react";
import { Navigate, useParams } from "react-router";
Expand Down Expand Up @@ -35,7 +34,6 @@ export const AccountDetail: React.FC<Props> = ({ groupId }) => {

const group = useGroup(groupId);
const account = useAccount(groupId, accountId);
const query = useQuery();

useTitle(
t(account?.type === "clearing" ? "accounts.detail.tabTitleEvent" : "accounts.detail.tabTitleAccount", "", {
Expand All @@ -45,11 +43,7 @@ export const AccountDetail: React.FC<Props> = ({ groupId }) => {
);

if (account === undefined) {
if (query.get("no-redirect") === "true") {
return <Loading />;
} else {
return <Navigate to="/404" />;
}
return <Navigate to={`/groups/${groupId}/accounts`} />;
}

if (account.is_wip) {
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/pages/accounts/AccountDetail/AccountInfo.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export const AccountInfo: React.FC<Props> = ({ groupId, account }) => {
// we saved a purely local account, i.e. we created a new account -> navigate to account list
navigate(getAccountListLink(groupId, "personal"));
} else if (oldAccountId !== newAccount.id) {
navigate(getAccountLink(groupId, newAccount.type, newAccount.id) + "?no-redirect=true", {
navigate(getAccountLink(groupId, newAccount.type, newAccount.id), {
replace: true,
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export const AccountTransactionList: React.FC<Props> = ({ groupId, account }) =>
)
.unwrap()
.then(({ transaction }) => {
navigate(`/groups/${groupId}/transactions/${transaction.id}?no-redirect=true`);
navigate(`/groups/${groupId}/transactions/${transaction.id}`);
})
.catch(() => toast.error("Creating a transaction failed"));
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export const ClearingAccountList: React.FC<Props> = ({ groupId }) => {
dispatch(createAccount({ groupId, type: "clearing" }))
.unwrap()
.then(({ account }) => {
navigate(getAccountLink(groupId, account.type, account.id) + "?no-redirect=true");
navigate(getAccountLink(groupId, account.type, account.id));
});
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export const PersonalAccountList: React.FC<Props> = ({ groupId }) => {
dispatch(createAccount({ groupId, type: "personal" }))
.unwrap()
.then(({ account }) => {
navigate(`/groups/${groupId}/accounts/${account.id}?no-redirect=true`);
navigate(`/groups/${groupId}/accounts/${account.id}`);
})
.catch((err) => {
toast.error(`Error while creating account: ${err}`);
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/pages/accounts/SettlementPlanDisplay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export const SettlementPlanDisplay: React.FC<Props> = ({ groupId }) => {
)
.unwrap()
.then(({ transaction }) => {
navigate(`/groups/${groupId}/transactions/${transaction.id}?no-redirect=true`);
navigate(`/groups/${groupId}/transactions/${transaction.id}`);
});
};

Expand Down
2 changes: 2 additions & 0 deletions apps/web/src/pages/groups/Group.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import {
fetchGroupDependencies,
selectGroupAccountsStatus,
selectGroupTransactionsStatus,
setAccountStatus,
setTransactionStatus,
useGroup,
} from "@abrechnung/redux";
import React, { Suspense } from "react";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { MobilePaper } from "@/components/style";
import { Loading } from "@abrechnung/components";
import { api } from "@/core/api";
import { useQuery, useTitle } from "@/core/utils";
import { useTitle } from "@/core/utils";
import { useAppDispatch, useAppSelector } from "@/store";
import {
deleteTransaction,
Expand Down Expand Up @@ -38,7 +37,6 @@ export const TransactionDetail: React.FC<Props> = ({ groupId }) => {
const { t } = useTranslation();
const params = useParams();
const dispatch = useAppDispatch();
const query = useQuery();
const navigate = useNavigate();
const transactionId = Number(params["id"]);

Expand Down Expand Up @@ -136,7 +134,7 @@ export const TransactionDetail: React.FC<Props> = ({ groupId }) => {
.then(({ oldTransactionId, transaction }) => {
setShowProgress(false);
if (oldTransactionId !== transaction.id) {
navigate(`/groups/${groupId}/transactions/${transaction.id}?no-redirect=true`, { replace: true });
navigate(`/groups/${groupId}/transactions/${transaction.id}`, { replace: true });
}
})
.catch((err) => {
Expand All @@ -146,11 +144,7 @@ export const TransactionDetail: React.FC<Props> = ({ groupId }) => {
}, [transaction, setPositionValidationErrors, dispatch, setShowProgress, navigate, groupId, transactionId]);

if (transaction === undefined) {
if (query.get("no-redirect") === "true") {
return <Loading />;
} else {
return <Navigate to="/404" />;
}
return <Navigate to={`/groups/${groupId}`} />;
}

return (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,14 +221,14 @@ export const TransactionList: React.FC<Props> = ({ groupId }) => {
dispatch(createTransaction({ groupId, type: "purchase" }))
.unwrap()
.then(({ transaction }) => {
navigate(`/groups/${groupId}/transactions/${transaction.id}?no-redirect=true`);
navigate(`/groups/${groupId}/transactions/${transaction.id}`);
});
};
const onCreateTransfer = () => {
dispatch(createTransaction({ groupId, type: "transfer" }))
.unwrap()
.then(({ transaction }) => {
navigate(`/groups/${groupId}/transactions/${transaction.id}?no-redirect=true`);
navigate(`/groups/${groupId}/transactions/${transaction.id}`);
});
};

Expand Down
27 changes: 17 additions & 10 deletions libs/redux/src/lib/accounts/accountSlice.ts
Original file line number Diff line number Diff line change
Expand Up @@ -407,14 +407,19 @@ const accountSlice = createSlice({
const s = getGroupScopedState<AccountState, AccountSliceState>(state, groupId);
removeEntity(s.wipAccounts, accountId);
},
setAccountStatus: (state, action: PayloadAction<{ groupId: number; status: StateStatus }>) => {
const { groupId, status } = action.payload;
initializeGroupState(state, groupId);
const s = getGroupScopedState<AccountState, AccountSliceState>(state, groupId);
if (s) {
s.status = status;
}
},
},
extraReducers: (builder) => {
builder.addCase(fetchAccounts.pending, (state, action) => {
const groupId = action.meta.arg.groupId;
if (!state.byGroupId[groupId]) {
// TODO: add separate base action to do this
initializeGroupState(state, groupId);
}
initializeGroupState(state, groupId);
});
builder.addCase(fetchAccounts.rejected, (state, action) => {
const s = getGroupScopedState<AccountState, AccountSliceState>(state, action.meta.arg.groupId);
Expand All @@ -423,10 +428,6 @@ const accountSlice = createSlice({
builder.addCase(fetchAccounts.fulfilled, (state, action) => {
const accounts = action.payload;
const groupId = action.meta.arg.groupId;
if (!state.byGroupId[groupId]) {
// TODO: add separate base action to do this
initializeGroupState(state, groupId);
}
const s = getGroupScopedState<AccountState, AccountSliceState>(state, groupId);
// TODO: optimize such that we maybe only update those who have actually changed??
const byId = accounts.reduce<{ [k: number]: Account }>((byId, account) => {
Expand Down Expand Up @@ -475,7 +476,13 @@ const accountSlice = createSlice({
// local reducers
const { advanceNextLocalAccountId } = accountSlice.actions;

export const { wipAccountUpdated, accountAdded, accountEditStarted, copyAccount, discardAccountChange } =
accountSlice.actions;
export const {
wipAccountUpdated,
accountAdded,
accountEditStarted,
copyAccount,
discardAccountChange,
setAccountStatus,
} = accountSlice.actions;

export const { reducer: accountReducer } = accountSlice;
6 changes: 4 additions & 2 deletions libs/redux/src/lib/thunks.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { PURGE } from "redux-persist";
import { Api } from "@abrechnung/api";
import { fetchAccounts } from "./accounts";
import { fetchTransactions } from "./transactions";
import { fetchAccounts, setAccountStatus } from "./accounts";
import { fetchTransactions, setTransactionStatus } from "./transactions";
import { IRootState } from "./types";
import { createAsyncThunkWithErrorHandling } from "./utils";

Expand All @@ -12,6 +12,8 @@ export const fetchGroupDependencies = createAsyncThunkWithErrorHandling<
>(
"fetchGroupDependencies",
async ({ groupId, api, fetchAnyway = false }, { dispatch }) => {
dispatch(setTransactionStatus({ groupId, status: "loading" }));
dispatch(setAccountStatus({ groupId, status: "loading" }));
await Promise.all([
dispatch(fetchAccounts({ groupId, api, fetchAnyway })).unwrap(),
dispatch(fetchTransactions({ groupId, api, fetchAnyway })).unwrap(),
Expand Down
14 changes: 10 additions & 4 deletions libs/redux/src/lib/transactions/transactionSlice.ts
Original file line number Diff line number Diff line change
Expand Up @@ -708,14 +708,19 @@ const transactionSlice = createSlice({
removeEntity(s.wipTransactions, transactionId);
delete s.wipTransactions.balanceEffects[transactionId];
},
setTransactionStatus: (state, action: PayloadAction<{ groupId: number; status: StateStatus }>) => {
const { groupId, status } = action.payload;
initializeGroupState(state, groupId);
const s = getGroupScopedState<TransactionState, TransactionSliceState>(state, groupId);
if (s) {
s.status = status;
}
},
},
extraReducers: (builder) => {
builder.addCase(fetchTransactions.pending, (state, action) => {
const groupId = action.meta.arg.groupId;
if (!state.byGroupId[groupId]) {
// TODO: add separate base action to do this
initializeGroupState(state, groupId);
}
initializeGroupState(state, groupId);
});
builder.addCase(fetchTransactions.rejected, (state, action) => {
const s = getGroupScopedState<TransactionState, TransactionSliceState>(state, action.meta.arg.groupId);
Expand Down Expand Up @@ -795,6 +800,7 @@ export const {
wipPositionAdded,
positionDeleted,
discardTransactionChange,
setTransactionStatus,
} = transactionSlice.actions;

export const { reducer: transactionReducer } = transactionSlice;