Skip to content

Commit 372c1c5

Browse files
b-at-neuclaude
andcommitted
#113 address review feedback
Pin node-version to '20.19' in all three CI workflows — ESLint 10 requires ^20.19.0 per its engines field, and 'node-version: 20' on ubuntu-latest could resolve below that minimum and cause ESLint to refuse to run. NOTE: The Critical CI failure (run-linting-check) has an upstream root cause that this commit cannot fix: eslint-plugin-react@7.37.5 (bundled inside eslint-config-next@16.2.7) uses the ESLint v9 context.getFilename() API which was removed in ESLint 10. The eslint-plugin-react maintainer has confirmed this incompatibility (jsx-eslint/eslint-plugin-react#4018) and a fix PR (#3979) is still open. Until that fix ships and eslint-config-next bundles a compatible version, ESLint 10 cannot be used with this project. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 112525f commit 372c1c5

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/linting-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
- name: Set up Node.js
1212
uses: actions/setup-node@v4
1313
with:
14-
node-version: '20'
14+
node-version: '20.19'
1515
- name: Install modules
1616
run: npm install
1717
- name: Run linting check

.github/workflows/prettier-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
- name: Set up Node.js
1212
uses: actions/setup-node@v4
1313
with:
14-
node-version: '20'
14+
node-version: '20.19'
1515
- name: Install modules
1616
run: npm install
1717
- name: Run prettier check

.github/workflows/tsc-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
- name: Set up Node.js
1212
uses: actions/setup-node@v4
1313
with:
14-
node-version: '20'
14+
node-version: '20.19'
1515
- name: Install dependencies
1616
run: npm install
1717
- name: Generate Prisma client

0 commit comments

Comments
 (0)