#285 address review feedback cycle 1

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: b-at-neu

components/layouts/user-menu.tsx

@@ -19,6 +19,7 @@ import { signOutUser } from '@/prisma/actions/auth';
 import { logoutBypassUser } from '@/prisma/services/dev-bypass';
 
 import type { NavIdentity } from '@/lib/types';
+import { isError } from '@/lib/utils';
 
 import {
   DropdownMenu,
@@ -72,8 +73,11 @@ export function UserMenu({
         await logoutBypassUser();
         return;
       }
+      // Optimistic success toast — fires before the server redirect so it
+      // displays regardless of which path (redirect or error) completes first.
+      toast.success('Signed out.');
       const result = await signOutUser();
-      if (result && 'error' in result) {
+      if (isError(result)) {
         toast.error(result.error);
       }
       // On success the server action redirects to /login — no client navigation needed.

prisma/actions/auth.ts

@@ -12,7 +12,8 @@ import type { ErrorType } from '@/lib/utils';
 // fragility that caused the 403 when sign-out was driven client-side.
 export async function signOutUser(): Promise<ErrorType | void> {
   const user = await getCurrentUser();
-  if (!user) redirect('/login');
+  // getCurrentUser() always redirects when unauthenticated; this throw is defense-in-depth.
+  if (!user) throw new Error('Unauthenticated');
 
   const result = await authServer.signOut();