Skip to content

#282 Show Page Name In Browser Tab Title#287

Merged
b-at-neu merged 2 commits into
devfrom
282-show-page-name-in-browser-tab-title
Jun 29, 2026
Merged

#282 Show Page Name In Browser Tab Title#287
b-at-neu merged 2 commits into
devfrom
282-show-page-name-in-browser-tab-title

Conversation

@b-at-neu

Copy link
Copy Markdown
Collaborator

Closes #282

Summary

  • Changed the root metadata.title.template separator from - to the bullet (U+2022)
  • Added metadata exports to every static page that was missing one (positions, applications, my-applications, users, global-questions, profile, login, dev-login)
  • Added generateMetadata functions to three dynamic [id] pages (application detail, position apply, position edit) so each tab shows a record-specific title
  • Left the dashboard page untouched — it correctly falls back to the bare Aplio default

Changes

  • app/layout.tsx — change template separator from - to
  • app/(main)/positions/page.tsx — add metadata.title = 'Positions'
  • app/(main)/(auth)/applications/page.tsx — add metadata.title = 'Applications'
  • app/(main)/(auth)/my-applications/page.tsx — add metadata.title = 'My Applications'
  • app/(main)/(auth)/users/page.tsx — add metadata.title = 'Users'
  • app/(main)/(auth)/global-questions/page.tsx — add metadata.title = 'Global Questions'
  • app/(main)/profile/page.tsx — add metadata.title = 'Profile'
  • app/login/page.tsx — add metadata.title = 'Sign In'
  • app/login/bypass/page.tsx — add metadata.title = 'Dev Login'
  • app/(main)/(auth)/applications/[id]/page.tsx — add generateMetadata returning applicant name; falls back to {} when not found
  • app/(main)/(auth)/positions/[id]/apply/page.tsx — add generateMetadata returning Apply: <title>; falls back to {} when not found
  • app/(main)/(auth)/positions/[id]/edit/page.tsx — add generateMetadata returning Edit: <title>; falls back to {} when not found

Testing plan

  • Run npm run dev and open each route, confirming browser tab text:
    • / (dashboard) → exactly Aplio (no suffix, no separator)
    • /positionsAplio • Positions
    • /applications (as admin/manager) → Aplio • Applications
    • /my-applicationsAplio • My Applications
    • /users (as admin) → Aplio • Users
    • /global-questions (as admin) → Aplio • Global Questions
    • /profileAplio • Profile
    • /loginAplio • Sign In
    • /login/bypassAplio • Dev Login
    • /positions/<id> (public detail) → Aplio • <Position Title>
    • /positions/<id>/applyAplio • Apply: <Position Title>
    • /positions/<id>/edit (as admin/manager) → Aplio • Edit: <Position Title>
    • /applications/<id> (as admin/manager) → Aplio • <Applicant Name>
  • Verify the separator renders as (bullet), not a hyphen or pipe
  • Navigate to a non-existent /positions/<bad-id> → tab falls back to Aplio (default), page shows not-found
  • Navigate to a non-existent /applications/<bad-id> → tab falls back to Aplio (default), page shows not-found

Automated checks

  • prettier: pass
  • eslint: pass
  • tsc: pass

Notes

The bullet character is U+2022 written literally in app/layout.tsx; it is distinct from a hyphen-minus or pipe. The dynamic generateMetadata functions reuse the same data-fetch calls the page already makes — Next.js/React request deduplication collapses identical fetches within a single request, so there is no extra DB cost.

@b-at-neu b-at-neu self-assigned this Jun 29, 2026
@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
aplio Ready Ready Preview, Comment Jun 29, 2026 9:30am

@b-at-neu b-at-neu added the ready for review PR ready for review agent label Jun 29, 2026
@b-at-neu b-at-neu added reviewing Review agent working (in-flight) and removed ready for review PR ready for review agent labels Jun 29, 2026

@b-at-neu b-at-neu left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review — Cycle 1 · needs revision

1 open — ⚪ Nit (see inline)

Comment thread app/(main)/(auth)/positions/[id]/apply/page.tsx Outdated
@b-at-neu b-at-neu added needs revision Review found issues that need fixing revising Revise agent working (in-flight) and removed reviewing Review agent working (in-flight) needs revision Review found issues that need fixing labels Jun 29, 2026
b-at-neu and others added 2 commits June 29, 2026 11:26
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@b-at-neu
b-at-neu force-pushed the 282-show-page-name-in-browser-tab-title branch from aadadde to cee54c9 Compare June 29, 2026 09:29
@b-at-neu

Copy link
Copy Markdown
Collaborator Author

Revision — Cycle 1

fixed R1-N1 · cee54c9

@b-at-neu b-at-neu added ready for review PR ready for review agent reviewing Review agent working (in-flight) and removed revising Revise agent working (in-flight) ready for review PR ready for review agent labels Jun 29, 2026

@b-at-neu b-at-neu left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review — Cycle 2 · approved

0 open — clean

@b-at-neu b-at-neu added approved Review passed, ready to merge and removed reviewing Review agent working (in-flight) labels Jun 29, 2026
@b-at-neu
b-at-neu merged commit a4d0304 into dev Jun 29, 2026
7 checks passed
@b-at-neu
b-at-neu deleted the 282-show-page-name-in-browser-tab-title branch June 29, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Review passed, ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show Page Name In Browser Tab Title

1 participant