Release 2.1.1 (#2)

# Release 2.1.1

## Bugfix
- Legacy bindings of ValueDisplay elements within UI did not work if deployed with VS Code AppSpace SDK
- UI differs if deployed via Appstudio or VS Code AppSpace SDK
- Fullscreen icon of iFrame was visible

Author: golluroSICKAG

CHANGELOG.md

@@ -1,6 +1,13 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## Release 2.1.1
+
+### Bugfix
+- Legacy bindings of ValueDisplay elements within UI did not work if deployed with VS Code AppSpace SDK
+- UI differs if deployed via Appstudio or VS Code AppSpace SDK
+- Fullscreen icon of iFrame was visible
+
 ## Release 2.1.0
 
 ### New features

CSK_Module_DeviceScanner/pages/pages/CSK_Module_DeviceScanner/CSK_Module_DeviceScanner.css

@@ -52,5 +52,5 @@
 
 .myCustomButton_CSK_Module_DeviceScanner {
   border-radius: 30px;
-  padding-right: 0px;
+  padding: 11px;
 }

CSK_Module_DeviceScanner/pages/pages/CSK_Module_DeviceScanner/CSK_Module_DeviceScanner.html

@@ -7,13 +7,12 @@
         <layout-row id="RowLayout13">
             <layout-column id="ColumnLayout14" style="align-items: stretch">
                 <layout-row id="RowLayout14" style="align-items: baseline">
-                    <davinci-value-display id="VD_Title" class="myCustomLabel_CSK_Module_DeviceScanner"
-                        value="Device Scanner">
-                    </davinci-value-display>
+                    <h1 id="Heading_Title" class="myCustomLabel_CSK_Module_DeviceScanner">
+                        Device Scanner
+                    </h1>
                     <davinci-value-display id="VD_Version">
-                        <crown-edpws-binding property="value" name="CSK_DeviceScanner/OnNewStatusModuleVersion"
-                            update-on-resume>
-                        </crown-edpws-binding>
+                        <crown-on property="value" crown-event="CSK_DeviceScanner/OnNewStatusModuleVersion">
+                        </crown-on>
                     </davinci-value-display>
                 </layout-row>
             </layout-column>
@@ -53,7 +52,7 @@
                                     <stacked-pane id="SP_Error" value="error">
                                         <davinci-callout id="Callout8" type="error">
                                             <span>
-												New config NOT accepted (maybe just temporarly active)! Trigger rescan to update the list.
+												New config NOT accepted (maybe just temporarly active)! Check if the device needs to be stopped first. Trigger rescan to update the list.
 											</span>
                                         </davinci-callout>
                                     </stacked-pane>
@@ -115,7 +114,8 @@
                                             <layout-column id="ColumnLayout12" style="align-items: center">
                                                 <davinci-button id="B_Scan"
                                                     class="myCustomButton_CSK_Module_DeviceScanner" type="outline"
-                                                    icon-position="append" title="Scan for Device" icon="action/search">
+                                                    title="Scan for Device">
+                                                    <davinci-icon icon="action/search"></davinci-icon>
                                                     <span></span>
                                                     <crown-binding event="submit"
                                                         name="CSK_DeviceScanner/scanForDevices" auto-commit>
@@ -209,8 +209,8 @@
                                             <layout-column id="ColumnLayout13" style="align-items: center">
                                                 <davinci-button id="B_SendConfig"
                                                     class="myCustomButton_CSK_Module_DeviceScanner" type="outline"
-                                                    icon-position="append" title="Send new config to device"
-                                                    icon="navigation/check">
+                                                    title="Send new config to device">
+                                                    <davinci-icon icon="navigation/check"></davinci-icon>
                                                     <span></span>
                                                     <crown-binding event="submit" name="CSK_DeviceScanner/sendNewConfig"
                                                         auto-commit>

CSK_Module_DeviceScanner/pages/src/converter.ts

@@ -9,6 +9,14 @@ export function invertStatusString(value) {
 export function changeStyle(theme) {
   const style: HTMLStyleElement = document.createElement('style');
   style.id ='blub'
+
+  const toggleSW = document.querySelectorAll("davinci-toggle-switch")
+  toggleSW.forEach((userItem) => {
+    const shadowToggle = userItem.shadowRoot
+    const finalToggleSW = shadowToggle?.querySelector('div')
+    finalToggleSW?.classList.add('hasIcon')
+  });
+
   if (theme == 'CSK_Style'){
     var headerToolbar = `.sopasjs-ui-header-toolbar-wrapper { background-color: #FFFFFF; }`
     var uiHeader = `.sopasjs-ui-header>.app-logo { margin-right:0px; }`

CSK_Module_DeviceScanner/pages/src/index.ts

@@ -12,6 +12,10 @@ document.addEventListener('sopasjs-ready', () => {
   page_Setup.remove();
 
   setTimeout(() => {
+    const element = document.querySelector("div.sjs-wrapper > div > div.sjs-fullscreen-toggle")
+    if(element) {
+      element.parentElement.removeChild(element)
+    }
     document.title = 'CSK_Module_DeviceScanner'
   }, 500);
 })

CSK_Module_DeviceScanner/project.mf.xml

@@ -128,7 +128,7 @@ Typically the feature of this module is used like this: +
             </serves>
         </crown>
         <meta key="author">SICK AG</meta>
-        <meta key="version">2.1.0</meta>
+        <meta key="version">2.1.1</meta>
         <meta key="priority">low</meta>
         <meta key="copy-protected">false</meta>
         <meta key="read-protected">false</meta>

README.md

@@ -14,6 +14,7 @@ For further information regarding the internal used functions / events check out
 Tested on:  
 |Device|Firmware|Module version|
 |--|--|--|
+|SICK AppEngine|V1.7.0|V2.1.1|
 |SICK AppEngine|V1.7.0|V2.1.0|
 |SIM1012|V2.4.2|V2.1.0|
 |SICK AppEngine|V1.3.2|<V2.1.0|

docu/CSK_Module_DeviceScanner.html

@@ -6,7 +6,7 @@
 <meta name="viewport" content="width=device-width, initial-scale=1.0">
 <meta name="generator" content="Asciidoctor 2.0.12">
 <meta name="author" content="SICK AG">
-<title>Documentation - CSK_Module_DeviceScanner 2.1.0</title>
+<title>Documentation - CSK_Module_DeviceScanner 2.1.1</title>
 <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css">
 <style>
 /* Stylesheet for CodeRay to match GitHub theme | MIT License | http://foundation.zurb.com */
@@ -615,10 +615,10 @@
 </head>
 <body class="article toc2 toc-left">
 <div id="header">
-<h1>Documentation - CSK_Module_DeviceScanner 2.1.0</h1>
+<h1>Documentation - CSK_Module_DeviceScanner 2.1.1</h1>
 <div class="details">
 <span id="author" class="author">SICK AG</span><br>
-<span id="revnumber">version 2.1.0,</span>
+<span id="revnumber">version 2.1.1,</span>
 <span id="revdate">2024-07-31</span>
 </div>
 <div id="toc" class="toc2">
@@ -696,7 +696,7 @@ <h2 id="_document_metadata">Document metadata</h2>
 </tr>
 <tr>
 <th class="tableblock halign-left valign-top"><p class="tableblock">Version</p></th>
-<td class="tableblock halign-left valign-top"><p class="tableblock">2.1.0</p></td>
+<td class="tableblock halign-left valign-top"><p class="tableblock">2.1.1</p></td>
 </tr>
 <tr>
 <th class="tableblock halign-left valign-top"><p class="tableblock">Date</p></th>
@@ -2107,7 +2107,7 @@ <h4 id="_overview_2">Overview</h4>
 </div>
 <div id="footer">
 <div id="footer-text">
-Version 2.1.0<br>
+Version 2.1.1<br>
 Last updated 2024-07-31 16:12:23 +0200
 </div>
 </div>