# Release 2.1.3 (#8)

# Release 2.1.3

## Improvements
- Check for BOM in XML file

## Bugfix
- Legacy bindings of ValueDisplay elements and FileUpload feature within UI did not work if deployed with VS Code AppSpace SDK
- UI differs if deployed via Appstudio or VS Code AppSpace SDK
- Fullscreen icon of iFrame was visible

Author: golluroSICKAG

CHANGELOG.md

@@ -1,6 +1,16 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## Release 2.1.3
+
+### Improvements
+- Check for BOM in XML file
+
+### Bugfix
+- Legacy bindings of ValueDisplay elements and FileUpload feature within UI did not work if deployed with VS Code AppSpace SDK
+- UI differs if deployed via Appstudio or VS Code AppSpace SDK
+- Fullscreen icon of iFrame was visible
+
 ## Release 2.1.2
 
 ### Bugfixes

CSK_Module_IODDInterpreter/pages/pages/CSK_Module_IODDInterpreter/CSK_Module_IODDInterpreter.css

@@ -69,5 +69,5 @@
 
 .myCustomButton_CSK_Module_IODDInterpreter {
   border-radius: 30px;
-  padding-right: 0px;
+  padding: 11px;
 }

CSK_Module_IODDInterpreter/pages/pages/CSK_Module_IODDInterpreter/CSK_Module_IODDInterpreter.html

@@ -1,7 +1,9 @@
 <layout-row id="RowLayout1" class="myCustomBackground_CSK_Module_IODDInterpreter">
     <layout-column id="ColumnLayout1" class="myCustomFrameNoColor_CSK_Module_IODDInterpreter"
         style="align-items: stretch">
-        <h2 id="H2_Title">IODD Read Data</h2>
+        <h1 id="Heading_Title" class="myCustomLabel_CSK_Module_IODDInterpreter">
+            IODD Read Data
+        </h1>
         <stacked-view id="SV_IsInstanceSelected">
             <stacked-pane id="SP_InstanceISSelected" value="true">
                 <layout-row id="RowLayout2" class="myCustomFrame_CSK_Module_IODDInterpreter">

CSK_Module_IODDInterpreter/pages/pages/CSK_Module_IODDInterpreter/CSK_Module_IODDInterpreter_ReadData.html

@@ -1,7 +1,9 @@
 <layout-row id="RowLayout1" class="myCustomBackground_CSK_Module_IODDInterpreter">
     <layout-column id="ColumnLayout1" class="myCustomFrameNoColor_CSK_Module_IODDInterpreter"
         style="align-items: stretch">
-        <h2 id="H2_Title">IODD Write Data</h2>
+        <h1 id="Heading_Title" class="myCustomLabel_CSK_Module_IODDInterpreter">
+            IODD Write Data
+        </h1>
         <stacked-view id="SV_IsInstanceSelected">
             <stacked-pane id="SP_InstanceIsSelected" value="true">
                 <layout-row id="RowLayout2">

CSK_Module_IODDInterpreter/pages/pages/CSK_Module_IODDInterpreter/CSK_Module_IODDInterpreter_WriteData.html

@@ -29,6 +29,14 @@ export function str2num(newstr){
 export function changeStyle(theme) {
   const style: HTMLStyleElement = document.createElement('style');
   style.id ='blub'
+
+  const toggleSW = document.querySelectorAll("davinci-toggle-switch")
+  toggleSW.forEach((userItem) => {
+    const shadowToggle = userItem.shadowRoot
+    const finalToggleSW = shadowToggle?.querySelector('div')
+    finalToggleSW?.classList.add('hasIcon')
+  });
+
   if (theme == 'CSK_Style'){
     var headerToolbar = `.sopasjs-ui-header-toolbar-wrapper { background-color: #FFFFFF; }`
     var uiHeader = `.sopasjs-ui-header>.app-logo { margin-right:0px; }`

CSK_Module_IODDInterpreter/pages/src/converter.ts

@@ -20,6 +20,10 @@ document.addEventListener('sopasjs-ready', () => {
   page_Setup.remove();
 
   setTimeout(() => {
+    const element = document.querySelector("div.sjs-wrapper > div > div.sjs-fullscreen-toggle")
+    if(element) {
+      element.parentElement.removeChild(element)
+    }
     document.title = 'CSK_Module_IODDInterpreter'
   }, 500);
 })

CSK_Module_IODDInterpreter/pages/src/index.ts

@@ -475,7 +475,7 @@ Module can provide chunks of IODD file in JSON format to describe some datapoint
             </serves>
         </crown>
         <meta key="author">SICK AG</meta>
-        <meta key="version">2.1.2</meta>
+        <meta key="version">2.1.3</meta>
         <meta key="priority">low</meta>
         <meta key="copy-protected">false</meta>
         <meta key="read-protected">false</meta>

CSK_Module_IODDInterpreter/project.mf.xml

@@ -221,10 +221,10 @@ end
 ---@return string newInstanceId Name of the created instance
 local function createNewInstance()
   local instanceNumber = ioddInterpreter_Model.helperFuncs.getTableSize(ioddInterpreter_Model.parameters.instances)
-  local newInstanceId = 'newIntance' .. tostring(instanceNumber)
+  local newInstanceId = 'newInstance' .. tostring(instanceNumber)
   while ioddInterpreter_Model.parameters.instances[newInstanceId] do
     instanceNumber = instanceNumber + 1
-    newInstanceId = 'newIntance' .. tostring(instanceNumber)
+    newInstanceId = 'newInstance' .. tostring(instanceNumber)
   end
   ioddInterpreter_Model.parameters.instances[newInstanceId] = {
     selectedReadParameters = {},

CSK_Module_IODDInterpreter/scripts/Sensors/IODDInterpreter/IODDInterpreter_Model.lua

@@ -412,7 +412,16 @@ local function parseXmlDeclaration(self, xml, f)
     f.match, f.endMatch, f.text = string.find(xml, self._PI, f.pos)
     if not f.match then 
         err(self, self._errstr.declErr, f.pos)
-    end 
+    end
+
+    -- Check for BOM
+    if f.match == 4 then
+      xml = string.sub(xml, 4)
+      f.match, f.endMatch, f.text = string.find(xml, self._PI, f.pos)
+      if not f.match then 
+          err(self, self._errstr.declErr, f.pos)
+      end
+    end
 
     if f.match ~= 1 then
         -- Must be at start of doc if present