Skip to content

Commit 252021a

Browse files
Release 3.1.0 (#2)
# Release 3.1.0 ## New features - Check if persistent data to load provides all relevant parameters. Otherwise add default values ## Improvements - Better instance handling regarding FlowConfig ## Bugfix - Legacy bindings of ValueDisplay elements within UI did not work if deployed with VS Code AppSpace SDK - UI differs if deployed via Appstudio or VS Code AppSpace SDK - Fullscreen icon of iFrame was visible
1 parent 75c7909 commit 252021a

15 files changed

Lines changed: 231 additions & 179 deletions

CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,19 @@
11
# Changelog
22
All notable changes to this project will be documented in this file.
33

4+
## Release 3.1.0
5+
6+
### New features
7+
- Check if persistent data to load provides all relevant parameters. Otherwise add default values
8+
9+
### Improvements
10+
- Better instance handling regarding FlowConfig
11+
12+
### Bugfix
13+
- Legacy bindings of ValueDisplay elements within UI did not work if deployed with VS Code AppSpace SDK
14+
- UI differs if deployed via Appstudio or VS Code AppSpace SDK
15+
- Fullscreen icon of iFrame was visible
16+
417
## Release 3.0.0
518

619
### New features

CSK_Module_MultiColorSelection/pages/pages/CSK_Module_MultiColorSelection/CSK_Module_MultiColorSelection.css

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,10 @@
44
max-width: none;
55
}
66

7-
.myViewer_CSK_Module_MultiColorSelection > div > div {
8-
max-height: 600px;
9-
min-height: 600px;
7+
.myViewer_CSK_Module_MultiColorSelection {
8+
width: 98%;
9+
height: 600px;
10+
margin: auto;
1011
}
1112

1213
.myCustomPlaceholder5pxHeight_CSK_Module_MultiColorSelection {
@@ -115,5 +116,5 @@
115116

116117
.myCustomButton_CSK_Module_MultiColorSelection {
117118
border-radius: 30px;
118-
padding-right: 0px;
119+
padding: 11px;
119120
}

CSK_Module_MultiColorSelection/pages/pages/CSK_Module_MultiColorSelection/CSK_Module_MultiColorSelection.html

Lines changed: 61 additions & 74 deletions
Large diffs are not rendered by default.

CSK_Module_MultiColorSelection/pages/src/converter.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,14 @@ export function changeID(id) {
1212
export function changeStyle(theme) {
1313
const style: HTMLStyleElement = document.createElement('style');
1414
style.id ='blub'
15+
16+
const toggleSW = document.querySelectorAll("davinci-toggle-switch")
17+
toggleSW.forEach((userItem) => {
18+
const shadowToggle = userItem.shadowRoot
19+
const finalToggleSW = shadowToggle?.querySelector('div')
20+
finalToggleSW?.classList.add('hasIcon')
21+
});
22+
1523
if (theme == 'CSK_Style'){
1624
var headerToolbar = `.sopasjs-ui-header-toolbar-wrapper { background-color: #FFFFFF; }`
1725
var uiHeader = `.sopasjs-ui-header>.app-logo { margin-right:0px; }`

CSK_Module_MultiColorSelection/pages/src/index.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ document.addEventListener('sopasjs-ready', () => {
1212
page_Setup.remove();
1313

1414
setTimeout(() => {
15+
const element = document.querySelector("div.sjs-wrapper > div > div.sjs-fullscreen-toggle")
16+
if(element) {
17+
element.parentElement.removeChild(element)
18+
}
1519
document.title = 'CSK_Module_MultiColorSelection'
1620
}, 500);
1721
})

CSK_Module_MultiColorSelection/project.mf.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,7 @@ IMPORTANT: As instances start their own threads, the module needs to be restarte
579579
</crown>
580580
</crown>
581581
<meta key="author">SICK AG</meta>
582-
<meta key="version">3.0.0</meta>
582+
<meta key="version">3.1.0</meta>
583583
<meta key="priority">low</meta>
584584
<meta key="copy-protected">false</meta>
585585
<meta key="read-protected">false</meta>

CSK_Module_MultiColorSelection/scripts/CSK_Module_MultiColorSelection.lua

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,9 @@ local multiColorSelection_Instances = {} -- Handle all instances
5050
local multiColorSelectionController = require('ImageProcessing/MultiColorSelection/MultiColorSelection_Controller')
5151

5252
if _G.availableAPIs.default and _G.availableAPIs.specific then
53-
local setInstanceHandle = require('ImageProcessing/MultiColorSelection/FlowConfig/MultiColorSelection_FlowConfig')
53+
require('ImageProcessing/MultiColorSelection/FlowConfig/MultiColorSelection_FlowConfig')
5454
table.insert(multiColorSelection_Instances, multiColorSelection_Model.create(1))
5555
multiColorSelectionController.setMultiColorSelection_Instances_Handle(multiColorSelection_Instances)
56-
setInstanceHandle(multiColorSelection_Instances)
5756
else
5857
_G.logger:warning("CSK_MultiColorSelection: Relevant CROWN(s) not available on device. Module is not supported...")
5958
end

CSK_Module_MultiColorSelection/scripts/CSK_MultiColorSelection_Processing.lua

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -391,9 +391,11 @@ local function handleOnNewProcessing(image, timestamp)
391391

392392
viewer:present()
393393

394-
Script.notifyEvent("MultiColorSelection_OnNewValueToForward" .. multiColorSelectionInstanceNumberString, 'MultiColorSelection_OnNewFoundBlobs', tostring(#blobs))
395-
Script.notifyEvent("MultiColorSelection_OnNewValueToForward" .. multiColorSelectionInstanceNumberString, 'MultiColorSelection_OnNewSizeSmallestBlob', string.format("%.1f",(blobMin)))
396-
Script.notifyEvent("MultiColorSelection_OnNewValueToForward" .. multiColorSelectionInstanceNumberString, 'MultiColorSelection_OnNewSizeBiggestBlob', string.format("%.1f",(blobMax)))
394+
if processingParams['activeInUI'] then
395+
Script.notifyEvent("MultiColorSelection_OnNewValueToForward" .. multiColorSelectionInstanceNumberString, 'MultiColorSelection_OnNewFoundBlobs', tostring(#blobs))
396+
Script.notifyEvent("MultiColorSelection_OnNewValueToForward" .. multiColorSelectionInstanceNumberString, 'MultiColorSelection_OnNewSizeSmallestBlob', string.format("%.1f",(blobMin)))
397+
Script.notifyEvent("MultiColorSelection_OnNewValueToForward" .. multiColorSelectionInstanceNumberString, 'MultiColorSelection_OnNewSizeBiggestBlob', string.format("%.1f",(blobMax)))
398+
end
397399

398400
return
399401
end

CSK_Module_MultiColorSelection/scripts/ImageProcessing/MultiColorSelection/FlowConfig/MultiColorSelection_FlowConfig.lua

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -7,26 +7,10 @@ require('ImageProcessing.MultiColorSelection.FlowConfig.MultiColorSelection_Imag
77
require('ImageProcessing.MultiColorSelection.FlowConfig.MultiColorSelection_OnNewResult')
88
require('ImageProcessing.MultiColorSelection.FlowConfig.MultiColorSelection_Process')
99

10-
-- Reference to the multiImageFilter_Instances handle
11-
local multiColorSelection_Instances
12-
1310
--- Function to react if FlowConfig was updated
1411
local function handleOnClearOldFlow()
1512
if _G.availableAPIs.default and _G.availableAPIs.specific then
16-
for i = 1, #multiColorSelection_Instances do
17-
if multiColorSelection_Instances[i].parameters.flowConfigPriority then
18-
CSK_MultiColorSelection.clearFlowConfigRelevantConfiguration()
19-
break
20-
end
21-
end
13+
CSK_MultiColorSelection.clearFlowConfigRelevantConfiguration()
2214
end
2315
end
2416
Script.register('CSK_FlowConfig.OnClearOldFlow', handleOnClearOldFlow)
25-
26-
--- Function to get access to the multiColorSelection_Instances
27-
---@param handle handle Handle of multiColorSelection_Instances object
28-
local function setMultiColorSelection_Instances_Handle(handle)
29-
multiColorSelection_Instances = handle
30-
end
31-
32-
return setMultiColorSelection_Instances_Handle

CSK_Module_MultiColorSelection/scripts/ImageProcessing/MultiColorSelection/MultiColorSelection_Controller.lua

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -699,9 +699,11 @@ Script.serveFunction('CSK_MultiColorSelection.getStatusModuleActive', getStatusM
699699

700700
local function clearFlowConfigRelevantConfiguration()
701701
for i = 1, #multiColorSelection_Instances do
702-
multiColorSelection_Instances[i].parameters.registeredEvent = ''
703-
Script.notifyEvent('MultiColorSelection_OnNewProcessingParameter', i, 'deregisterFromEvent', '')
704-
Script.notifyEvent('MultiColorSelection_OnNewStatusRegisteredEvent', '')
702+
if multiColorSelection_Instances[i].parameters.flowConfigPriority then
703+
multiColorSelection_Instances[i].parameters.registeredEvent = ''
704+
Script.notifyEvent('MultiColorSelection_OnNewProcessingParameter', i, 'deregisterFromEvent', '')
705+
Script.notifyEvent('MultiColorSelection_OnNewStatusRegisteredEvent', '')
706+
end
705707
end
706708
end
707709
Script.serveFunction('CSK_MultiColorSelection.clearFlowConfigRelevantConfiguration', clearFlowConfigRelevantConfiguration)
@@ -755,6 +757,8 @@ local function loadParameters()
755757
_G.logger:info(nameOfModule .. ": Loaded parameters for multiColorSelectionInstance " .. tostring(selectedInstance) .. " from CSK_PersistentData module.")
756758
multiColorSelection_Instances[selectedInstance].parameters = helperFuncs.convertContainer2Table(data)
757759

760+
multiColorSelection_Instances[selectedInstance].parameters = helperFuncs.checkParameters(multiColorSelection_Instances[selectedInstance].parameters, helperFuncs.defaultParameters.getParameters())
761+
758762
-- Send config to instances
759763
local colorParams = helperFuncs.convertTable2Container(multiColorSelection_Instances[selectedInstance].parameters.colorObjects)
760764
Container.add(data, 'colorObjects', colorParams, 'OBJECT')
@@ -844,7 +848,11 @@ Script.register("CSK_PersistentData.OnInitialDataLoaded", handleOnInitialDataLoa
844848

845849
local function resetModule()
846850
if _G.availableAPIs.default and _G.availableAPIs.specific then
847-
clearFlowConfigRelevantConfiguration()
851+
for i = 1, #multiColorSelection_Instances do
852+
multiColorSelection_Instances[i].parameters.registeredEvent = ''
853+
Script.notifyEvent('MultiColorSelection_OnNewProcessingParameter', i, 'deregisterFromEvent', '')
854+
Script.notifyEvent('MultiColorSelection_OnNewStatusRegisteredEvent', '')
855+
end
848856
pageCalled()
849857
end
850858
end

0 commit comments

Comments
 (0)