Release 4.2.1 (#4)

golluroSICKAG · web-flow · commit 38a9ffc0d5a4 · 2025-05-20T13:30:10.000+02:00
# Release 4.2.1

## Bugfix
- Legacy bindings of ValueDisplay elements and FileUpload feature within UI did not work if deployed with VS Code AppSpace SDK
- UI differs if deployed via Appstudio or VS Code AppSpace SDK
- Fullscreen icon of iFrame was visible
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,13 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## Release 4.2.1
+
+### Bugfix
+- Legacy bindings of ValueDisplay elements and FileUpload feature within UI did not work if deployed with VS Code AppSpace SDK
+- UI differs if deployed via Appstudio or VS Code AppSpace SDK
+- Fullscreen icon of iFrame was visible
+
 ## Release 4.2.0
 
 ### New features
diff --git a/CSK_Module_PersistentData/pages/pages/CSK_Module_PersistentData/CSK_Module_PersistentData.css b/CSK_Module_PersistentData/pages/pages/CSK_Module_PersistentData/CSK_Module_PersistentData.css
@@ -72,5 +72,5 @@
 
 .myCustomButton_CSK_Module_PersistentData {
   border-radius: 30px;
-  padding-right: 0px;
+  padding: 11px;
 }
diff --git a/CSK_Module_PersistentData/pages/pages/CSK_Module_PersistentData/CSK_Module_PersistentData.html b/CSK_Module_PersistentData/pages/pages/CSK_Module_PersistentData/CSK_Module_PersistentData.html
diff --git a/CSK_Module_PersistentData/pages/src/converter.ts b/CSK_Module_PersistentData/pages/src/converter.ts
@@ -5,6 +5,14 @@ export function convertToList(value) {
 export function changeStyle(theme) {
   const style: HTMLStyleElement = document.createElement('style');
   style.id ='blub'
+
+  const toggleSW = document.querySelectorAll("davinci-toggle-switch")
+  toggleSW.forEach((userItem) => {
+    const shadowToggle = userItem.shadowRoot
+    const finalToggleSW = shadowToggle?.querySelector('div')
+    finalToggleSW?.classList.add('hasIcon')
+  });
+
   if (theme == 'CSK_Style'){
     var headerToolbar = `.sopasjs-ui-header-toolbar-wrapper { background-color: #FFFFFF; }`
     var uiHeader = `.sopasjs-ui-header>.app-logo { margin-right:0px; }`
diff --git a/CSK_Module_PersistentData/pages/src/index.ts b/CSK_Module_PersistentData/pages/src/index.ts
@@ -12,6 +12,10 @@ document.addEventListener('sopasjs-ready', () => {
   page_Setup.remove();
 
   setTimeout(() => {
+    const element = document.querySelector("div.sjs-wrapper > div > div.sjs-fullscreen-toggle")
+    if(element) {
+      element.parentElement.removeChild(element)
+    }
     document.title = 'CSK_Module_PersistentData'
   }, 500);
 })
diff --git a/CSK_Module_PersistentData/project.mf.xml b/CSK_Module_PersistentData/project.mf.xml
@@ -305,7 +305,7 @@ To make this permanent, it is needed to save the persistent data afterwards (see
             </serves>
         </crown>
         <meta key="author">SICK AG</meta>
-        <meta key="version">4.2.0</meta>
+        <meta key="version">4.2.1</meta>
         <meta key="priority">low</meta>
         <meta key="copy-protected">false</meta>
         <meta key="read-protected">false</meta>
diff --git a/docu/CSK_Module_PersistentData.html b/docu/CSK_Module_PersistentData.html
@@ -6,7 +6,7 @@
 <meta name="viewport" content="width=device-width, initial-scale=1.0">
 <meta name="generator" content="Asciidoctor 2.0.12">
 <meta name="author" content="SICK AG">
-<title>Documentation - CSK_Module_PersistentData 4.2.0</title>
+<title>Documentation - CSK_Module_PersistentData 4.2.1</title>
 <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css">
 <style>
 /* Stylesheet for CodeRay to match GitHub theme | MIT License | http://foundation.zurb.com */
@@ -615,10 +615,10 @@
 </head>
 <body class="article toc2 toc-left">
 <div id="header">
-<h1>Documentation - CSK_Module_PersistentData 4.2.0</h1>
+<h1>Documentation - CSK_Module_PersistentData 4.2.1</h1>
 <div class="details">
 <span id="author" class="author">SICK AG</span><br>
-<span id="revnumber">version 4.2.0,</span>
+<span id="revnumber">version 4.2.1,</span>
 <span id="revdate">2025-01-24</span>
 </div>
 <div id="toc" class="toc2">
@@ -730,7 +730,7 @@ <h2 id="_document_metadata">Document metadata</h2>
 </tr>
 <tr>
 <th class="tableblock halign-left valign-top"><p class="tableblock">Version</p></th>
-<td class="tableblock halign-left valign-top"><p class="tableblock">4.2.0</p></td>
+<td class="tableblock halign-left valign-top"><p class="tableblock">4.2.1</p></td>
 </tr>
 <tr>
 <th class="tableblock halign-left valign-top"><p class="tableblock">Date</p></th>
@@ -3751,7 +3751,7 @@ <h6 id="_sample_auto_generated_63">Sample (auto-generated)</h6>
 </div>
 <div id="footer">
 <div id="footer-text">
-Version 4.2.0<br>
+Version 4.2.1<br>
 Last updated 2025-01-24 10:43:07 +0100
 </div>
 </div>

Original file line number	Diff line number	Diff line change
`@@ -72,5 +72,5 @@`
`72`	`72`
`73`	`73`	`.myCustomButton_CSK_Module_PersistentData {`
`74`	`74`	`border-radius: 30px;`
`75`		`- padding-right: 0px;`
	`75`	`+ padding: 11px;`
`76`	`76`	`}`