ci(mypy): SR-190 — enforce type-checking (informational phase)

* ci(mypy): SR-190 — add informational mypy step after ruff (#189)

Re-applied cleanly on top of merged main (post-#173 path doctrine).

- Runs after 'ruff check', before 'pytest'.
- Matrix-pinned to Python 3.13 (Issue #189 acceptance criterion).
- Non-blocking via '|| true' + '--no-error-summary' -> Phase 1.
- Scope: survey-cli/survey/ (production code; tests out-of-scope).
- Full doctrine as inline comment in workflow (docs-in-code).

Note on operator: GHA runs each 'run:' block with 'bash -e -o pipefail'.
Under set -e, 'cmd1; cmd2' aborts after cmd1 if it fails. MUST use
'|| true' here. This was the operator-fix lesson from the first
revision of this PR (commit af826de on the pre-rebase branch).

Ref #189

* docs(agents): SR-190 — append mypy CI doctrine section (#189)

Appended at the tail of survey-cli/AGENTS.md (post-#173 path
doctrine section, post 'Out-of-scope' subsection):
  - Phase 1 contract (informational, non-blocking, scope, config).
  - Operator-gotcha note (|| true vs ; true under bash -e).
  - Promotion trigger for Phase 2 (count < 50 -> blocking).
  - Audit trail with date + baseline measurement.
  - Forbidden list (no --ignore-missing-imports, no per-module
    overrides without debt issue, no tests/ scope).

Ref #189

Author: Delqhi

.github/workflows/ci.yml

@@ -73,6 +73,31 @@ jobs:
       - name: Run ruff check
         run: ruff check survey-cli/survey --select E,W,F
 
+      # SR-190 (Issue #189) — mypy in CI, Phase 1: INFORMATIONAL ONLY.
+      # ----------------------------------------------------------------
+      # Doctrine (full rationale lives at the tail of survey-cli/AGENTS.md
+      # under "SR-190 - mypy in CI"). Short form here for the next agent:
+      # - Scope: survey-cli/survey/ (Production-Code). Tests OUT-OF-SCOPE.
+      # - Config: survey-cli/pyproject.toml has [tool.mypy] strict = true.
+      #   We respect that config; no CLI overrides here.
+      # - Matrix-Pin: ONLY runs on Python 3.13 (avoids double-counts in CI
+      #   logs and matches Issue #189's Python-3.13-as-baseline requirement).
+      # - Non-blocking: `|| true` forces exit 0. GitHub Actions runs each
+      #   `run:` block with `bash -e -o pipefail`, so `; true` would NOT
+      #   swallow mypy's non-zero exit — `set -e` aborts after `;`. You
+      #   MUST use `|| true` here.
+      # - --no-error-summary keeps raw `error:` lines grep-able from logs
+      #   (count via `grep -c "error:"`). Baseline at first run was 1075.
+      # - Promotion to Phase 2 (blocking): when count drops below 50, drop
+      #   the `|| true` and the `--no-error-summary`, then update the
+      #   AGENTS.md SR-190 block to "Phase 2 ACTIVE".
+      # - DO NOT add `--ignore-missing-imports` here. DO NOT inline
+      #   per-module overrides — those belong in pyproject.toml and need
+      #   a separate debt issue (precedent: SR-62/SR-63 for ruff/pytest).
+      - name: Type-check with mypy (SR-190 — informational phase)
+        if: matrix.python-version == '3.13'
+        run: cd survey-cli && mypy survey/ --no-error-summary 2>&1 || true
+
       - name: Run survey-cli tests
         env:
           PYTHONPATH: survey-cli

survey-cli/AGENTS.md

@@ -265,3 +265,41 @@ content: |
   in separate, narrowly-scoped PRs that the guard itself makes safe to
   land. Mixing governance and bulk-delete into one PR is exactly how
   SR-154 happened.
+  
+  ---
+  
+  ##  SR-190 - mypy in CI (gradually enforcing types)
+  
+  **Status:** Phase 1 ACTIVE — informational only, non-blocking.
+  
+  **What happens:**
+  - CI workflow `.github/workflows/ci.yml` runs `mypy survey/` after
+    `ruff check` and before `pytest`, only on the Python 3.13 matrix leg.
+  - Scope: `survey-cli/survey/` (production code). Tests OUT-OF-SCOPE.
+  - Config: `survey-cli/pyproject.toml` -> `[tool.mypy] strict = true`.
+  - Exit code is forced to 0 via `|| true` (GHA shells run with
+    `bash -e -o pipefail`, so `; true` would NOT swallow the failure
+    — `set -e` aborts after `;`. MUST use `|| true`).
+  - `--no-error-summary` keeps raw `error:` lines grep-able in the log
+    (count via `grep -c "error:"`).
+  
+  **Why not blocking yet:**
+  - Baseline = 1075 errors (PR #193, run 25785123606).
+  - Hard gate would paint every PR red -> velocity killer.
+  - Phase 1 = visibility. Real bugs surfaced by mypy (60 attr-defined,
+    63 union-attr) get fixed as small surgical PRs under SR-194
+    (#198-#202, #210/#211/#213/#214/#217).
+  
+  **Promotion trigger to Phase 2 (blocking):**
+  - When error count < 50: drop the `|| true` and `--no-error-summary`,
+    then flip this block to "Phase 2 ACTIVE".
+  
+  **Audit trail:**
+  - 2026-05-13 (SR-190 / PR #193): step introduced. Baseline 1075 errors.
+    No local run, no clone — implemented entirely via GitHub API.
+  
+  **Forbidden:**
+  - NO `--ignore-missing-imports` CLI flag in the workflow.
+  - NO per-module `[[tool.mypy.overrides]]` without a separate debt
+    issue (precedent: SR-62/SR-63 for ruff/pytest).
+  - NO type-check on `survey-cli/tests/` in this phase.