Skip to content

Commit f29bf43

Browse files
DelqhiCEO-Agent
authored andcommitted
fixup(SR-173): correct cross-references SR-167 #167 / SR-168 #168
The Protocol-Shim TODOs and AGENTS.md brain-section referenced #173/#174 as the placeholder issue numbers for SR-167/SR-168, but the canonical numbers are: - SR-167 -> issue #167 (Post-Action Verifier Node) - SR-168 -> issue #168 (Triple-Channel Attestation) #173 is actually SR-159 Path Doctrine. Fix all references in: - survey/observability/visual_debug.py (Protocol docstrings + TODOs) - survey/runner_policy.py (related-issues block) - survey-cli/AGENTS.md (SR-173 brain-section) No runtime change. Tests still 12/12 green.
1 parent ccc9188 commit f29bf43

3 files changed

Lines changed: 11 additions & 11 deletions

File tree

survey-cli/AGENTS.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,12 +207,12 @@ content: |
207207
```
208208
209209
### Wann erweitern (Roadmap-Hooks)
210-
- **SR-167 (#173) merged**\: in `visual_debug.py` ersetze
210+
- **SR-167 (#167) merged**\: in `visual_debug.py` ersetze
211211
`class VerificationResultLike(Protocol)` durch
212212
`from survey.reliability.verifier import VerificationResult`. Type-Alias
213213
behalten\: `VerificationResultLike = VerificationResult` falls Downstream-
214214
Code den Shim referenziert.
215-
- **SR-168 (#174) merged**\: analog für `AttestationResultLike`. Plus\:
215+
- **SR-168 (#168) merged**\: analog für `AttestationResultLike`. Plus\:
216216
`network_pending_at_click` field in die Daten-Quelle einhängen
217217
(gelangt heute schon durch -- braucht nur den Producer).
218218
- **SR-172 (#172) meta-tracker**\: nach Merge dieses PRs Checkbox abhaken.

survey-cli/survey/observability/visual_debug.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -86,17 +86,17 @@
8686
8787
PROTOCOL SHIMS FOR SR-167 / SR-168
8888
==================================
89-
`VerificationResult` (from SR-167 / #173) and `AttestationResult` (from
90-
SR-168 / #174) are not yet merged on `main` at the time SR-173 was implemented.
89+
`VerificationResult` (from SR-167 / #167) and `AttestationResult` (from
90+
SR-168 / #168) are not yet merged on `main` at the time SR-173 was implemented.
9191
We declare `typing.Protocol`-based shims here so:
9292
9393
- this module compiles + tests run today;
9494
- once SR-167/168 land, the *only* change is replacing the Protocol import
9595
with a `from survey.reliability.verifier import VerificationResult` in
9696
the type-checker's eyes -- no run-time changes.
9797
98-
TODO(SR-167 / #173): swap VerificationResultLike for the real dataclass.
99-
TODO(SR-168 / #174): swap AttestationResultLike for the real dataclass.
98+
TODO(SR-167 / #167): swap VerificationResultLike for the real dataclass.
99+
TODO(SR-168 / #168): swap AttestationResultLike for the real dataclass.
100100
101101
COST BUDGET (defended in PR review)
102102
===================================
@@ -122,8 +122,8 @@
122122
RELATED ISSUES
123123
==============
124124
- #178 (SR-173) -- this file.
125-
- #173 (SR-167) -- post-action verifier; provides VerificationResult.
126-
- #174 (SR-168) -- triple-channel attestation; provides AttestationResult.
125+
- #167 (SR-167) -- post-action verifier; provides VerificationResult.
126+
- #168 (SR-168) -- triple-channel attestation; provides AttestationResult.
127127
- #172 (SR-172) -- meta-tracker for the reliability push.
128128
"""
129129

@@ -166,7 +166,7 @@
166166
# (a) snapshot.py already has 900+ lines and we should not bloat it for SR-173;
167167
# (b) Box/Point/ElementRef are *observability* concepts in our codebase --
168168
# the snapshot module only deals with CompactSnapshot today.
169-
# TODO(SR-167 / #173): once verifier.py lands, consider promoting these to a
169+
# TODO(SR-167 / #167): once verifier.py lands, consider promoting these to a
170170
# shared `survey.geometry` module if more than two callers need them.
171171

172172
@dataclass(frozen=True, slots=True)

survey-cli/survey/runner_policy.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@
5151
RELATED ISSUES
5252
==============
5353
- SR-173 (#178) — introduced this file; visual-debug fields.
54-
- SR-167 (#173) — verifier; will add `verifier_strict_mode` here when merged.
55-
- SR-168 (#174) — attestation; will add `attestation_threshold` here when merged.
54+
- SR-167 (#167) — verifier; will add `verifier_strict_mode` here when merged.
55+
- SR-168 (#168) — attestation; will add `attestation_threshold` here when merged.
5656
"""
5757

5858
from __future__ import annotations

0 commit comments

Comments
 (0)