Commit 6065f9d
fix(gemma): write MLIR dump tests to portable build dir, not a hardcoded local path
GemmaMlirDumpTest and RealGemmaMlirDumpTest defaulted their StableHLO dump
output to /home/miso/projects/coral/build-mlir/, the original author's local
checkout. On CI (home is /home/runner) parentFile.mkdirs() can't create that
tree, so writeText throws FileNotFoundException and :llm-inference:gemma:allTests
fails — turning develop (and every PR branched off it) red.
The Gemma3 -> StableHLO lowering itself is healthy (0 unsupported ops, 0 arity
gaps); only the final file write was broken. Default to the module's build/
dir (build/build-mlir/*.mlir), which both tests already mkdirs and which is
writable everywhere. The -DgemmaMlirOut=<path> override is unchanged.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent feed359 commit 6065f9d
2 files changed
Lines changed: 2 additions & 2 deletions
File tree
- llm-inference/gemma/src/jvmTest/kotlin/sk/ainet/models/gemma
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
| 59 | + | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
86 | | - | |
| 86 | + | |
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
| |||
0 commit comments