Commit 9f4dde7
fix(ci): opt out of AGP config-time-resolution check in project gradle.properties; fix stale Q8_0 test
Real fix for the Build & Test failure (was masked by, then surfaced after, the
JS NPM config-time issue):
1. `gradle.properties`: set `android.dependencyResolutionAtConfigurationTime.disallow=false`.
AGP's DependencyResolutionChecks fails the build when KGP's KotlinPackageJsonTask
resolves the Kotlin/JS + Wasm `*NpmAggregated` configs at configuration time
(we have JS npm deps: ktor-client-js, kotlinx-browser) — `assemble`/`allTests`
threw `Configuration 'jsNpmAggregated' was resolved during configuration time`
(gradle#31483), a false positive against KGP's known behaviour. AGP reads this
option ONLY from the project gradle.properties — NOT from `-P` or the CI's
~/.gradle/gradle.properties (which is why the earlier attempts didn't take).
Reverted those no-op attempts (build.yml/publish.yml `-P`, ci-gradle.properties).
2. `GemmaQuantLayoutTest`: `pack_non_kquant_returns_null` asserted Q8_0 packs to
null, but #179 added Q8_0 packing — it now returns Q8_0BlockTensorData. Replace
with `pack_q8_0_produces_block_tensor` + a true-null case (Q4_1).
Verified locally: `clean assemble allTests --no-configuration-cache` is GREEN.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 65dc347 commit 9f4dde7
5 files changed
Lines changed: 22 additions & 15 deletions
File tree
- .github
- workflows
- llm-inference/gemma/src/commonTest/kotlin/sk/ainet/models/gemma
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
49 | 48 | | |
50 | 49 | | |
51 | 50 | | |
| |||
57 | 56 | | |
58 | 57 | | |
59 | 58 | | |
60 | | - | |
61 | 59 | | |
62 | 60 | | |
63 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
36 | 45 | | |
37 | 46 | | |
38 | 47 | | |
| |||
Lines changed: 12 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
55 | 56 | | |
56 | 57 | | |
57 | 58 | | |
58 | | - | |
59 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
60 | 70 | | |
61 | 71 | | |
62 | 72 | | |
| |||
0 commit comments