chore(build): drop deprecated kotlin("stdlib-common") from KMP modules#108
Merged
michalharakal merged 1 commit intodevelopfrom May 4, 2026
Merged
chore(build): drop deprecated kotlin("stdlib-common") from KMP modules#108michalharakal merged 1 commit intodevelopfrom
michalharakal merged 1 commit intodevelopfrom
Conversation
Kotlin 2.x unified `kotlin-stdlib-common` into `kotlin-stdlib`, and the
kotlin-multiplatform plugin auto-adds the stdlib to commonMain. The
explicit `api(kotlin("stdlib-common"))` declarations are deprecated and
were the suspected (latent) cause of the metadata/JS classpath
regression tracked in #105. Removing them keeps build files current
with Kotlin 2.x and removes a footgun.
Verified across :llm-api, :llm-core, :llm-performance:
compileCommonMainKotlinMetadata, compileKotlinJvm, compileKotlinJs
all build cleanly with --rerun-tasks --no-build-cache.
Refs #105.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api(kotlin("stdlib-common"))fromllm-api,llm-core, andllm-performancecommonMain.dependencies.kotlin-stdlib-commonintokotlin-stdlib, and thekotlin-multiplatformplugin auto-adds the stdlib tocommonMain, so the explicit declaration is deprecated and redundant.Scope / non-claims
compileCommonMainKotlinMetadataandcompileKotlinJsfail on basic stdlib references #105. The symptom described in develop:compileCommonMainKotlinMetadataandcompileKotlinJsfail on basic stdlib references #105 (compileCommonMainKotlinMetadataandcompileKotlinJsfailing with unresolved stdlib references) no longer reproduces on currentdevelop— it appears to have been resolved indirectly by intervening changes (Feature/tranformers api fix #106 / chore(release): prepare 0.23.1 — version-align with SKaiNET 0.23.1 #107). The deprecated reference removed here was a suspected contributing factor and a latent footgun, not a confirmed root cause.Test plan
./gradlew :llm-api:compileCommonMainKotlinMetadata :llm-api:compileKotlinJvm :llm-api:compileKotlinJs --rerun-tasks --no-build-cache:llm-coreand:llm-performance— all 9 tasksBUILD SUCCESSFUL, noUnresolved referenceerrors.🤖 Generated with Claude Code