Rename fromGGUFData to fromByteArray in factories.

Related-To: #121 #95

Author: michalharakal

skainet-core/skainet-tensors/src/commonMain/kotlin/sk/ainet/core/tensor/factory/FP16TensorFactory.kt

@@ -28,7 +28,7 @@ public object FP16TensorFactory : TensorFactoryRegistry.TensorFromBytesFactory<F
      * @return A new FP16 tensor instance
      * @throws NotImplementedError Currently not implemented
      */
-    override fun fromGGUFData(shape: Shape, data: ByteArray): Tensor<FP16, Float> {
+    override fun fromByteArray(shape: Shape, data: ByteArray): Tensor<FP16, Float> {
         // Validate data size for FP16 (2 bytes per value)
         val expectedBytes = shape.volume * 2
         require(data.size == expectedBytes) {

skainet-core/skainet-tensors/src/commonMain/kotlin/sk/ainet/core/tensor/factory/FP32TensorFactory.kt

@@ -19,7 +19,7 @@ public object FP32TensorFactory : TensorFactoryRegistry.TensorFromBytesFactory<F
      * @return A new CpuTensorFP32 instance
      * @throws IllegalArgumentException if data size doesn't match expected float count
      */
-    override fun fromGGUFData(shape: Shape, data: ByteArray): Tensor<FP32, Float> {
+    override fun fromByteArray(shape: Shape, data: ByteArray): Tensor<FP32, Float> {
         // Validate input data size matches shape requirements
         val expectedFloatCount = shape.volume
         val expectedByteSize = expectedFloatCount * 4 // 4 bytes per float

skainet-core/skainet-tensors/src/commonMain/kotlin/sk/ainet/core/tensor/factory/Int32TensorFactory.kt

@@ -18,7 +18,7 @@ public object Int32TensorFactory : TensorFactoryRegistry.TensorFromBytesFactory<
      * @return A new CpuTensorInt32 instance
      * @throws IllegalArgumentException if data size doesn't match expected int count
      */
-    override fun fromGGUFData(shape: Shape, data: ByteArray): Tensor<Int32, Int> {
+    override fun fromByteArray(shape: Shape, data: ByteArray): Tensor<Int32, Int> {
         // Validate input data size matches shape requirements
         val expectedIntCount = shape.volume
         val expectedByteSize = expectedIntCount * 4 // 4 bytes per int

skainet-core/skainet-tensors/src/commonMain/kotlin/sk/ainet/core/tensor/factory/Int4TensorFactory.kt

@@ -38,7 +38,7 @@ public object Int4TensorFactory : TensorFactoryRegistry.TensorFromBytesFactory<I
      * @return A new Int4 tensor instance
      * @throws NotImplementedError Currently not implemented
      */
-    override fun fromGGUFData(shape: Shape, data: ByteArray): Tensor<Int4, Byte> {
+    override fun fromByteArray(shape: Shape, data: ByteArray): Tensor<Int4, Byte> {
         // Validate data size for packed Int4 (2 values per byte, rounded up)
         val expectedBytes = (shape.volume + 1) / 2  // Ceiling division for odd volumes
         require(data.size == expectedBytes) {

skainet-core/skainet-tensors/src/commonMain/kotlin/sk/ainet/core/tensor/factory/Int8TensorFactory.kt

@@ -18,7 +18,7 @@ public object Int8TensorFactory : TensorFactoryRegistry.TensorFromBytesFactory<I
      * @return A new CpuTensorInt8 instance
      * @throws IllegalArgumentException if data size doesn't match expected byte count
      */
-    override fun fromGGUFData(shape: Shape, data: ByteArray): Tensor<Int8, Byte> {
+    override fun fromByteArray(shape: Shape, data: ByteArray): Tensor<Int8, Byte> {
         // Validate input data size matches shape requirements
         val expectedByteCount = shape.volume
 
@@ -36,13 +36,13 @@ public object Int8TensorFactory : TensorFactoryRegistry.TensorFromBytesFactory<I
 
     /**
      * Creates a tensor from byte data with validation.
-     * This method is identical to fromGGUFData since Int8 doesn't need endianness conversion.
+     * This method is identical to fromByteArray since Int8 doesn't need endianness conversion.
      * @param shape The desired shape of the tensor
      * @param data The byte array containing the tensor data
      * @return A new CpuTensorInt8 instance
      */
     public fun fromByteData(shape: Shape, data: ByteArray): Tensor<Int8, Byte> {
-        return fromGGUFData(shape, data)
+        return fromByteArray(shape, data)
     }
 
     /**

skainet-core/skainet-tensors/src/commonMain/kotlin/sk/ainet/core/tensor/factory/TensorFactoryDocumentation.kt

@@ -146,7 +146,7 @@ import sk.ainet.core.tensor.Tensor
  * 
  * // Example: Custom factory for Q4_0
  * object Q4_0TensorFactory : TensorFactoryRegistry.TensorFromBytesFactory<Q4_0, Byte> {
- *     override fun fromGGUFData(shape: Shape, data: ByteArray): Tensor<Q4_0, Byte> {
+ *     override fun fromByteArray(shape: Shape, data: ByteArray): Tensor<Q4_0, Byte> {
  *         // Validate packed 4-bit data
  *         val expectedBytes = (shape.volume + 1) / 2 // 2 values per byte
  *         require(data.size == expectedBytes) {

skainet-core/skainet-tensors/src/commonMain/kotlin/sk/ainet/core/tensor/factory/TensorFactoryRegistry.kt

@@ -32,7 +32,7 @@ public object TensorFactoryRegistry {
          * @param data The byte array containing the tensor data
          * @return A new tensor instance
          */
-        public fun fromGGUFData(shape: Shape, data: ByteArray): Tensor<T, V>
+        public fun fromByteArray(shape: Shape, data: ByteArray): Tensor<T, V>
     }
 
     /**
@@ -67,7 +67,7 @@ public object TensorFactoryRegistry {
         // 4.5: Add logging/debugging support for factory operations
         try {
             @Suppress("UNCHECKED_CAST")
-            val result = (factory as TensorFromBytesFactory<DType, Any>).fromGGUFData(shape, data)
+            val result = (factory as TensorFromBytesFactory<DType, Any>).fromByteArray(shape, data)
 
             // Debug logging (can be enabled by setting debugLogging flag)
             if (debugLogging) {

skainet-core/skainet-tensors/src/commonMain/kotlin/sk/ainet/core/tensor/factory/TernaryTensorFactory.kt

@@ -42,7 +42,7 @@ public object TernaryTensorFactory : TensorFactoryRegistry.TensorFromBytesFactor
      * @return A new Ternary tensor instance
      * @throws NotImplementedError Currently not implemented
      */
-    override fun fromGGUFData(shape: Shape, data: ByteArray): Tensor<Ternary, Byte> {
+    override fun fromByteArray(shape: Shape, data: ByteArray): Tensor<Ternary, Byte> {
         // Validate data size for packed Ternary (4 values per byte, rounded up)
         val expectedBytes = (shape.volume + 3) / 4  // Ceiling division for non-multiples of 4
         require(data.size == expectedBytes) {

skainet-core/skainet-tensors/src/commonTest/kotlin/sk/ainet/core/tensor/factory/FP32TensorFactoryTest.kt

@@ -40,7 +40,7 @@ class FP32TensorFactoryTest {
         val floats = floatArrayOf(1.0f, 2.0f, 3.0f, 4.0f)
         val bytes = createFloatBytes(floats)
 
-        val tensor = FP32TensorFactory.fromGGUFData(shape, bytes)
+        val tensor = FP32TensorFactory.fromByteArray(shape, bytes)
 
         assertNotNull(tensor, "Tensor should be created")
         assertEquals(shape, tensor.shape, "Shape should match")
@@ -59,7 +59,7 @@ class FP32TensorFactoryTest {
         val floats = floatArrayOf(1.0f, 2.0f, 3.0f, 4.0f, 5.0f, 6.0f)
         val bytes = createFloatBytes(floats)
 
-        val tensor = FP32TensorFactory.fromGGUFData(shape, bytes)
+        val tensor = FP32TensorFactory.fromByteArray(shape, bytes)
 
         assertNotNull(tensor, "Tensor should be created")
         assertEquals(shape, tensor.shape, "Shape should match")
@@ -81,7 +81,7 @@ class FP32TensorFactoryTest {
         val floats = floatArrayOf(1.0f, 2.0f, 3.0f, 4.0f, 5.0f, 6.0f, 7.0f, 8.0f)
         val bytes = createFloatBytes(floats)
 
-        val tensor = FP32TensorFactory.fromGGUFData(shape, bytes)
+        val tensor = FP32TensorFactory.fromByteArray(shape, bytes)
 
         assertNotNull(tensor, "Tensor should be created")
         assertEquals(shape, tensor.shape, "Shape should match")
@@ -100,7 +100,7 @@ class FP32TensorFactoryTest {
         val floats = FloatArray(16) { (it + 1).toFloat() } // [1.0, 2.0, ..., 16.0]
         val bytes = createFloatBytes(floats)
 
-        val tensor = FP32TensorFactory.fromGGUFData(shape, bytes)
+        val tensor = FP32TensorFactory.fromByteArray(shape, bytes)
 
         assertNotNull(tensor, "Tensor should be created")
         assertEquals(shape, tensor.shape, "Shape should match")
@@ -118,7 +118,7 @@ class FP32TensorFactoryTest {
         val floats = FloatArray(10000) { it.toFloat() }
         val bytes = createFloatBytes(floats)
 
-        val tensor = FP32TensorFactory.fromGGUFData(shape, bytes)
+        val tensor = FP32TensorFactory.fromByteArray(shape, bytes)
 
         assertNotNull(tensor, "Large tensor should be created")
         assertEquals(shape, tensor.shape, "Shape should match")
@@ -147,7 +147,7 @@ class FP32TensorFactoryTest {
         val shape = Shape(8)
         val bytes = createFloatBytes(specialFloats)
 
-        val tensor = FP32TensorFactory.fromGGUFData(shape, bytes)
+        val tensor = FP32TensorFactory.fromByteArray(shape, bytes)
 
         assertNotNull(tensor, "Tensor with special values should be created")
         assertEquals(shape, tensor.shape, "Shape should match")
@@ -170,7 +170,7 @@ class FP32TensorFactoryTest {
         val wrongSizeBytes = ByteArray(12) // Only 12 bytes (3 floats)
 
         assertFailsWith<IllegalArgumentException>("Should throw for wrong byte array size") {
-            FP32TensorFactory.fromGGUFData(shape, wrongSizeBytes)
+            FP32TensorFactory.fromByteArray(shape, wrongSizeBytes)
         }
     }
 
@@ -182,13 +182,13 @@ class FP32TensorFactoryTest {
         // Test with zero dimension
         assertFailsWith<IllegalArgumentException>("Should throw for zero dimension") {
             val invalidShape = Shape(0, 4)
-            FP32TensorFactory.fromGGUFData(invalidShape, bytes)
+            FP32TensorFactory.fromByteArray(invalidShape, bytes)
         }
 
         // Test with negative dimension
         assertFailsWith<IllegalArgumentException>("Should throw for negative dimension") {
             val invalidShape = Shape(-1, 4)
-            FP32TensorFactory.fromGGUFData(invalidShape, bytes)
+            FP32TensorFactory.fromByteArray(invalidShape, bytes)
         }
     }
 
@@ -199,7 +199,7 @@ class FP32TensorFactoryTest {
         val emptyBytes = ByteArray(0)
 
         assertFailsWith<IllegalArgumentException>("Should throw for empty byte array") {
-            FP32TensorFactory.fromGGUFData(shape, emptyBytes)
+            FP32TensorFactory.fromByteArray(shape, emptyBytes)
         }
     }
 
@@ -210,7 +210,7 @@ class FP32TensorFactoryTest {
         val misalignedBytes = ByteArray(7) // Not divisible by 4
 
         assertFailsWith<IllegalArgumentException>("Should throw for misaligned bytes") {
-            FP32TensorFactory.fromGGUFData(shape, misalignedBytes)
+            FP32TensorFactory.fromByteArray(shape, misalignedBytes)
         }
     }
 
@@ -221,7 +221,7 @@ class FP32TensorFactoryTest {
         val floats = floatArrayOf(42.0f)
         val bytes = createFloatBytes(floats)
 
-        val tensor = FP32TensorFactory.fromGGUFData(shape, bytes)
+        val tensor = FP32TensorFactory.fromByteArray(shape, bytes)
 
         assertNotNull(tensor, "Minimal tensor should be created")
         assertEquals(shape, tensor.shape, "Shape should match")
@@ -239,7 +239,7 @@ class FP32TensorFactoryTest {
             val floats = FloatArray(size) { it.toFloat() }
             val bytes = createFloatBytes(floats)
 
-            val tensor = FP32TensorFactory.fromGGUFData(shape, bytes)
+            val tensor = FP32TensorFactory.fromByteArray(shape, bytes)
 
             assertNotNull(tensor, "Tensor of size $size should be created")
             assertEquals(shape, tensor.shape, "Shape should match for size $size")
@@ -273,7 +273,7 @@ class FP32TensorFactoryTest {
             val floats = FloatArray(expectedVolume) { (it + 1).toFloat() }
             val bytes = createFloatBytes(floats)
 
-            val tensor = FP32TensorFactory.fromGGUFData(shape, bytes)
+            val tensor = FP32TensorFactory.fromByteArray(shape, bytes)
 
             assertNotNull(tensor, "Tensor with shape $shape should be created")
             assertEquals(shape, tensor.shape, "Shape should match for $shape")
@@ -296,7 +296,7 @@ class FP32TensorFactoryTest {
         val shape = Shape(6)
         val bytes = createFloatBytes(preciseFloats)
 
-        val tensor = FP32TensorFactory.fromGGUFData(shape, bytes)
+        val tensor = FP32TensorFactory.fromByteArray(shape, bytes)
 
         assertNotNull(tensor, "Precision tensor should be created")
         assertEquals(shape, tensor.shape, "Shape should match")