🔧 chore: update exception handling to catch Throwable in SpongeConfigManager

twisti-dev · twisti-dev · commit 237710f92a8b · 2026-05-16T15:25:36.000+02:00
- change catch block from Exception to Throwable to handle broader error cases
diff --git a/surf-api-core/surf-api-core/src/main/kotlin/dev/slne/surf/api/core/config/manager/SpongeConfigManager.kt b/surf-api-core/surf-api-core/src/main/kotlin/dev/slne/surf/api/core/config/manager/SpongeConfigManager.kt
@@ -245,7 +245,7 @@ class SpongeConfigManager<C> private constructor(
                         try {
                             OldSpongeReflections.OLD_CONFIG_SERIALIZABLE_ANNOTATION // If this throws an exception, there are no none relocated annotations, no need to register — most likely the standalone version
                             serializers.registerBackwardsCompatibleSerializers()
-                        } catch (_: Exception) {
+                        } catch (_: Throwable) {
                             // no none relocated annotations, no need to register
                         }
                     }.shouldCopyDefaults(true)

Original file line number	Diff line number	Diff line change
`@@ -245,7 +245,7 @@ class SpongeConfigManager<C> private constructor(`
`245`	`245`	`try {`
`246`	`246`	`OldSpongeReflections.OLD_CONFIG_SERIALIZABLE_ANNOTATION // If this throws an exception, there are no none relocated annotations, no need to register — most likely the standalone version`
`247`	`247`	`serializers.registerBackwardsCompatibleSerializers()`
`248`		`- } catch (_: Exception) {`
	`248`	`+ } catch (_: Throwable) {`
`249`	`249`	`// no none relocated annotations, no need to register`
`250`	`250`	`}`
`251`	`251`	`}.shouldCopyDefaults(true)`