Commit d1abef3
committed
fix: correct ConditionalOnMissingComponent inheritance check
Fix isAssignableFrom direction in evaluateMissingComponentConditions
to properly check if loaded components are assignable to the missing
component type. Previously checked the inverse relationship, causing
incorrect conditional component loading.
Also refactored to use Class.forName with the component's classLoader
instead of Kotlin reflection for more reliable class comparison across
different plugin classloaders.1 parent 83146c1 commit d1abef3
2 files changed
Lines changed: 11 additions & 5 deletions
File tree
- surf-api-core/surf-api-core-server/src/main/kotlin/dev/slne/surf/surfapi/core/server/component
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
Lines changed: 10 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
233 | 233 | | |
234 | 234 | | |
235 | 235 | | |
236 | | - | |
| 236 | + | |
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
| |||
291 | 291 | | |
292 | 292 | | |
293 | 293 | | |
| 294 | + | |
294 | 295 | | |
295 | 296 | | |
296 | 297 | | |
297 | 298 | | |
298 | | - | |
299 | | - | |
300 | | - | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
301 | 307 | | |
302 | 308 | | |
303 | 309 | | |
| |||
0 commit comments