♻️ refactor(service): improve requirement caching for connected players

- check player connection status before caching requirement
- store requirement result in cache only if player is connected

Author: twisti-dev

surf-api-paper/surf-api-paper-server/src/main/kotlin/dev/slne/surf/api/paper/server/command/SuspendRequirementServiceImpl.kt

@@ -151,7 +151,10 @@ class SuspendRequirementServiceImpl : SuspendRequirementService {
         suspend fun refreshForSender(sender: Player) {
             withContext(scope().coroutineContext.minusKey(Job)) {
                 try {
-                    cached.put(sender.uniqueId, requirement(sender))
+                    val isRequirementMet = requirement(sender)
+                    if (sender.isConnected) { // check if this player instance is still connected
+                        cached.put(sender.uniqueId, isRequirementMet)
+                    }
                 } catch (e: Throwable) {
                     if (e is CancellationException) throw e
                     log.atWarning()