"CASTCRAFTER COMMUNITY SERVER" has been renamed to "CASTCRAFTER.DE" to match the new™️ logo.#104
Closed
TheBjoRedCraft wants to merge 1 commit into
Closed
"CASTCRAFTER COMMUNITY SERVER" has been renamed to "CASTCRAFTER.DE" to match the new™️ logo.#104TheBjoRedCraft wants to merge 1 commit into
TheBjoRedCraft wants to merge 1 commit into
Conversation
Member
Author
|
@twisti-dev Du musst noch die gh action fixen |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the disconnect message header to use the new branding “CASTCRAFTER.DE” instead of “CASTCRAFTER\nCOMMUNITY SERVER” in both the implementation and its example documentation.
- Replaced the two-line header in
DISCONNECT_HEADERwith a single “CASTCRAFTER.DE” line. - Updated four
**Output Example:**comment blocks to reflect the new header.
Comments suppressed due to low confidence (2)
surf-api-core/surf-api-core-api/src/main/kotlin/dev/slne/surf/surfapi/core/api/messages/CommonComponents.kt:77
- Add a unit test to verify that
DISCONNECT_HEADERoutputs "CASTCRAFTER.DE" with the correct formatting and newline count.
appendText("CASTCRAFTER.DE", PRIMARY)
surf-api-core/surf-api-core-api/src/main/kotlin/dev/slne/surf/surfapi/core/api/messages/CommonComponents.kt:132
- [nitpick] The
**Output Example:**header is duplicated across multiple sections; consider referencing the sharedDISCONNECT_HEADERconstant or extracting the example into a single template to reduce duplication and ease future updates.
* CASTCRAFTER.DE
Contributor
|
What are the reasons for wanting to switch to CastCrafter.de in a disconnect header? |
Member
Author
|
We're switching to CastCrafter.de in the disconnect header to match the new logo — it's already noted in Trello. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
DISCONNECT_HEADERtext in theCommonComponentsobject to reflect a branding change. The text now uses "CASTCRAFTER.DE" instead of the previous "CASTCRAFTER" and "COMMUNITY SERVER" lines.Branding update in
DISCONNECT_HEADER:DISCONNECT_HEADERoutput example and implementation to replace "CASTCRAFTER" and "COMMUNITY SERVER" with "CASTCRAFTER.DE" across multiple instances. (surf-api-core/surf-api-core-api/src/main/kotlin/dev/slne/surf/surfapi/core/api/messages/CommonComponents.kt) [1] [2] [3] [4] [5]