feat: enhance message prefixes for consistency and clarity#168
Closed
TheBjoRedCraft wants to merge 3 commits into
Closed
feat: enhance message prefixes for consistency and clarity#168TheBjoRedCraft wants to merge 3 commits into
TheBjoRedCraft wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances message prefix consistency by introducing a simplified default prefix and adding specialized prefix variants for different message types (errors, warnings, and internal "Surf" branding). The default PREFIX is simplified to just a spacer symbol without internal branding, while a new SURF_PREFIX maintains the original branded format for internal use.
- Simplified the default
PREFIXcomponent to remove the "Surf" branding for public messages - Added three new prefix variants:
SURF_PREFIXfor internal messages,ERROR_PREFIXfor errors, andWARNING_PREFIXfor warnings - Added a
white()color function to the SurfComponentBuilder for displaying white text
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| surf-api-core/surf-api-core-api/src/main/kotlin/dev/slne/surf/surfapi/core/api/messages/Colors.kt | Defines the new prefix components (PREFIX, SURF_PREFIX, WARNING_PREFIX, ERROR_PREFIX) with updated documentation |
| surf-api-core/surf-api-core-api/src/main/kotlin/dev/slne/surf/surfapi/core/api/messages/builder/SurfComponentBuilder.kt | Adds convenience methods for appending the new prefixes and introduces the white() color function |
| gradle.properties | Bumps the version from 1.21.10-2.42.3 to 1.21.10-2.42.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…surfapi/core/api/messages/Colors.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.