feat: add support for surf-core api integration#175
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for core modules in the Gradle plugin configuration, mirroring the existing cloud module pattern. The implementation allows projects to declare dependencies on platform-specific core modules (Common, Paper, Velocity) through the Gradle plugin extension.
Key changes:
- Introduced
SurfCoreModulesenum to define available core module types - Extended plugin extensions with
coreModuleproperty and helper methods (withCoreCommon,withCorePaper,withCoreVelocity) - Updated plugin dependency registration to include core modules in Paper and Velocity plugin descriptors
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SurfCoreModules.kt | New enum defining the three core module types (COMMON, PAPER, VELOCITY) with their Maven artifact names |
| CommonSurfExtension.kt | Added coreModule property to hold the selected core module; minor formatting improvement to publishingUrl property |
| CoreSurfExtension.kt | Added three convenience methods (withCoreCommon, withCorePaper, withCoreVelocity) to configure core module dependencies |
| CommonSurfPlugin.kt | Added dependency configuration logic to include the selected core module as a compile-only dependency |
| PaperPluginSurfPlugin.kt | Registered surf-core-paper as a required server dependency when core module is present |
| VelocityPluginFile.kt | Registered surf-core-velocity as a required plugin dependency when core module is present |
| build.gradle.kts | Incremented plugin version from 1.6.4 to 1.6.5 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
twisti-dev
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.