Fix/plugin file generation#213
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Gradle plugin’s release version and simplifies plugin-file generation by removing a redundant Gradle extension registration in the shared plugin-file generation base class.
Changes:
- Bump
surf-api-gradle-pluginversion suffix from-1.12.0to-1.12.1. - Remove an unnecessary
extensions.add(...)call when creating the plugin-file extension object.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/surfapi/gradle/platform/common/CommonSurfPluginWithPluginFile.kt |
Drops redundant extension re-registration; plugin-file generation continues to use the created extension instance. |
surf-api-gradle-plugin/build.gradle.kts |
Updates the published plugin version suffix to -1.12.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains two minor changes: a version bump and the removal of an unnecessary extension registration. These updates help keep the project versioning accurate and streamline the plugin file generation process.
Versioning update:
build.gradle.ktsfrom-1.12.0to-1.12.1to reflect the new release version.Code simplification:
extensions.addcall for the plugin file inCommonSurfPluginWithPluginFile.kt, as it is no longer needed for plugin file generation.